Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WSL: Add WSL command #416

Merged
merged 1 commit into from
Nov 30, 2023
Merged

WSL: Add WSL command #416

merged 1 commit into from
Nov 30, 2023

Conversation

Asartea
Copy link
Contributor

@Asartea Asartea commented Sep 15, 2023

DO NOT MERGE: Depends on TheOdinProject/curriculum/pull/25402

Because

  • We're moving to support WSL2

This PR

  • Adds a new command to direct users to the wsl channel for support

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Callbacks command: Update verbiage
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If applicable, I have ensured all tests related to any command files included in this PR pass, and/or all snapshots are up to date

@KevinMulhern KevinMulhern reopened this Sep 16, 2023
@KevinMulhern
Copy link
Member

Ignore the closing and reopens - trying to retrigger CI using this PR

@ManonLef ManonLef added the Status: Do Not Merge This PR should not be merged until further notice label Sep 16, 2023
@KevinMulhern KevinMulhern reopened this Sep 16, 2023
@KevinMulhern KevinMulhern reopened this Sep 16, 2023
@Asartea Asartea marked this pull request as draft September 16, 2023 18:13
@01zulfi
Copy link
Member

01zulfi commented Nov 17, 2023

Hey @Asartea, do let me know when this is ready for review along with #417 #418

@Asartea Asartea marked this pull request as ready for review November 17, 2023 07:00
@Asartea
Copy link
Contributor Author

Asartea commented Nov 17, 2023

@01zulfi should all be ready for review

@xandora xandora merged commit 9e3abed into TheOdinProject:main Nov 30, 2023
@Asartea Asartea deleted the add-wsl-command branch November 30, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@01zulfi 01zulfi 01zulfi approved these changes

Assignees
No one assigned
Labels
Status: Do Not Merge This PR should not be merged until further notice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Asartea @KevinMulhern @01zulfi @xandora @ManonLef