Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foundations / Installation Overview: Preliminary WSL2 Introduction #25402
Foundations / Installation Overview: Preliminary WSL2 Introduction #25402
Changes from 27 commits
84b141c
b20a9c8
0813506
387c6da
0f51df9
4498f05
962de65
56974f0
76075b6
aaed4a3
5bcab2a
fc020ba
054fea4
b1310a9
3c10c72
c335d9d
e0aee95
e89efba
af01020
9d85c25
d2915ad
64d8989
18f2f53
0e29b52
4d8f8e9
9b85906
90a534c
53806c5
238c977
3f873b7
19f6396
5c009f5
e2db87c
192489d
617be6b
ed953f9
0ebd80d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need the rename to dog.jpg step here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker, but could be good to include instructions if a user doesn't have this enabled. "Alternatively, open the "Customize and control Google Chrome" kebab menu and select the "Downloads" item. This will show all of your downloads, each with its own "Show in folder" button."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to reply to this, but this is ✅ Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance we can add a cool little gif of this action to illustrate the point?
EDIT: See the wsl2 channel for a potential option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we should still include some alternative instructions to drag and drop, even it means warning that copy pasting or whatever other way may result in a (harmless) duplicate file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a small amount of dragging and dropping with the alternative:
cd ~/odin-links-and-images
for example)cp <space>
"/mnt/c/users/username/Downloads/dog.jpg"
<space> .
to tellcp
that you want to copy the file to your current working directorycp "/mnt/c/users/username/Downloads/dog.jpg" .
ls
to confirm the file now existsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alternative alternative is to just do this:
This does get the
:Zone.Identifier
file, but doesn't use drag 'n dropThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the solution is as simple as updating the verbiage to "Either drag and drop or copy and paste..." or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the extra explanation by @xandora , which I think should be enough. If we see that lots of learners on Discord run into issues at this step we can always add extra instructions