Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS: Add generic OS command #417

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Conversation

Asartea
Copy link
Contributor

@Asartea Asartea commented Sep 15, 2023

DO NOT MERGE: Depends on TheOdinProject/curriculum/pull/25402

Because

  • Once we've moved to support WSL, its easier to disclaim that every OS not mentioned isn't supported, rather than trying to account for every possible edgecase (But what about TempleOS???)

This PR

  • Adds a generic !os command which makes it clear that everything not mentioned as supported is unsupported

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Callbacks command: Update verbiage
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If this PR adds new features or functionality, I have added new tests
  • If applicable, I have ensured all tests related to any command files included in this PR pass, and/or all snapshots are up to date

@Asartea Asartea mentioned this pull request Sep 15, 2023
7 tasks
@ManonLef ManonLef added the Status: Do Not Merge This PR should not be merged until further notice label Sep 16, 2023
@Asartea Asartea marked this pull request as draft September 16, 2023 18:13
@01zulfi 01zulfi mentioned this pull request Nov 17, 2023
5 tasks
@Asartea Asartea marked this pull request as ready for review November 17, 2023 07:00
@xandora xandora merged commit 427f208 into TheOdinProject:main Nov 30, 2023
@Asartea Asartea deleted the add-os-command branch November 30, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Do Not Merge This PR should not be merged until further notice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants