Doc Expansion #890
Merged
Doc Expansion #890
+425
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed `AutoLoop` to `AutoRoutine` Fixed `auto-routines` doc examples after removal of `TriggerExt`
…Routine` and some docs
…-> `AutoRoutine` and some docs" This reverts commit adcab05.
- changed `atTimeAndPlace` to `atTimeAndPose` - removed unused `timeOffset` member from `AutoTrajectory` - inlined some methods only used once - added easier flipping to trajectory sample fetching - added method to get the underlying trajectory of an `AutoTrajectory`
shueja
requested changes
Nov 7, 2024
Co-authored-by: shueja <[email protected]>
Co-authored-by: shueja <[email protected]>
spacey-sooty
requested changes
Nov 16, 2024
|
I like the restructuring of the .md files, but I'll want to do a final spelling/wording pass before merging this. |
Fix grammar / wording / sidebar
shueja
requested changes
Nov 17, 2024
Co-authored-by: shueja <[email protected]>
Co-authored-by: shueja <[email protected]>
spacey-sooty
previously requested changes
Nov 22, 2024
shueja
approved these changes
Nov 22, 2024
| The "Auto Controller" is a function that consumes a `Pose2d` as well as a sample (`SwerveSample` or `DifferentialSample` depending on drive base). | ||
| The controller should capture your drive subsystem to directly control it. | ||
|
|
||
| ## Basic PID Controller |
There was a problem hiding this comment.
This particular implementation is overkill. I think we should recommend a function in the drivebase subsystem, which captures the subsystem and PID controllers. This is how the CTRE examples work.
|
Approved for merge. My one remaining comment can be tackled in a later PR because the currently recommended code does work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires #884 to be merged first