BUG: Initialize _Controller Init Parameters
#703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gui-FernandesBR
force-pushed
the
bug/init-variables-save-on-self
branch
from
ed80d4e to
ddbccb3
Compare
Gui-FernandesBR
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
@MateusStano I know you don't like the CHANGELOG.md file.
But keep in mind that, when you don't update it, someone else you have to do it for you.
In the case of last 3 PRs, that one was me.
| @@ -84,8 +84,10 @@ def __init__( | |||
| None | |||
| """ | |||
| self.interactive_objects = interactive_objects | |||
| self.base_controller_function = controller_function | |||
There was a problem hiding this comment.
@MateusStano I have no idea why you want to save this attribute as base_controller_functioninstead of simply controller_function. I'm approving this since the class is still private.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #703 +/- ##
===========================================
- Coverage 76.02% 75.90% -0.12%
===========================================
Files 99 99
Lines 11278 11222 -56
===========================================
- Hits 8574 8518 -56
Misses 2704 2704 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some arguments passed to
__init__of the_Controllerclass were not being saved. This PR fixes this issueThis is important for controller/airbrakes serialization.
Should be merged after #701