Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): sourced person queries #17470

Closed
wants to merge 43 commits into from
Closed

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Sep 15, 2023

This PR will likely be split up for easier review.

Problem

The persons modal often doesn't show exactly what the chart itself does.

Changes

Instead of endlessly aligning separate queries, let's reuse the same query for the persons modal for the new HogQL insights.

  • Support custom tables in the inline HogQL editor (different validation for PersonsQuery & EventsQuery)
  • In addition to the /person/:distinct_id url, add a /persons/:uuid that loads data from ClickHouse.
  • Add View SQL and Edit SQL buttons whenever a response contains the "hogql" field.
  • Make those look good
  • Replace the old persons scene with one that uses the PersonsQuery
  • Lifecycle insight's persons open through a PersonsQuery
  • Back to chart from persons (works, kind of)
  • Lifecycle persons query supports breakdowns/options
  • Support placeholders values when making a HogQLQuery. This avoids frontend string serialization woes.
  • Consolidate query runners into a get_query_runner(node)
  • Create a select pdi.distinct_id from persons magic join
  • Tests for PersonsQuery
  • Out of scope: refactor events query.

How did you test this code?

WIP

@mariusandra mariusandra mentioned this pull request Sep 18, 2023
48 tasks
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@mariusandra
Copy link
Collaborator Author

Everything from here is either merged, in here, or a discarded back button.

@mariusandra mariusandra deleted the persons-query-runners branch October 18, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants