Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(queries): consolidate query runners #17732

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Conversation

mariusandra
Copy link
Collaborator

Problem

Splitting out work from #17470

Changes

Consolidates query runners into a get_query_runner method, which will later be used to get a runner for the PersonsQuery's source to extract its persons.

How did you test this code?

All API calls and tests for those queries still work.

Copy link
Member

@robbie-c robbie-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will give me a tiny merge conflict but I accept :)

@mariusandra mariusandra merged commit 70379e7 into master Oct 3, 2023
66 checks passed
@mariusandra mariusandra deleted the consolidate-query-runners branch October 3, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants