feat(hogql): edit hogql expressions for tables other than 'events' #17736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Splitting out work from #17470
Changes
Adds a
tablefield to theHogQLMetadataquery. This will be used when evaluating/validating HogQL expressions (e.g.properties.bla).For now, every place that uses the HogQL editor will still validate the expression against the
eventstable. Persons are coming soon.How did you test this code?
Clicked around, everything worked as before. In the linked PR that has implements PersonsQuerys, this is tested with persons and works.