Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(persons): rename urls.person(id) to urls.personDistinctId(id) #17734

Merged
merged 3 commits into from
Oct 3, 2023
Merged

feat(persons): rename urls.person(id) to urls.personDistinctId(id) #17734

merged 3 commits into from
Oct 3, 2023

Conversation

mariusandra
Copy link
Collaborator

Problem

Splitting out work from #17470

Changes

  • Renames urls.person(id) to urls.personDistinctId(id)
  • This makes a future urls.personUUID(id) unambiguous.

How did you test this code?

CI, and nothing broke in the big PR.

Twixes
Twixes reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe personByDistinctId? Since personDistinctId sounds like it would point to a distinct ID's page

@mariusandra
Copy link
Collaborator Author

Why not. Changed it.

@mariusandra mariusandra merged commit 265072a into master Oct 3, 2023
72 checks passed
@mariusandra mariusandra deleted the person-distinct-id-urls branch October 3, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

@Gilbert09 Gilbert09 Gilbert09 approved these changes

@thmsobrmlr thmsobrmlr Awaiting requested review from thmsobrmlr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariusandra @Gilbert09 @Twixes