Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP - Talawa #2108

Closed
palisadoes opened this issue Nov 16, 2023 · 9 comments · Fixed by #2114
Closed

MVP - Talawa #2108

palisadoes opened this issue Nov 16, 2023 · 9 comments · Fixed by #2114
Assignees
Labels
documentation Update documentation feature request no-issue-activity No issue activity test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Nov 16, 2023

We need to have an Talawa MVP by the end of the year. The MVP will be the master branch. To do this we will need to remove features that either don’t work or have insufficient functionality.

The features to remove include:

  1. Links to chat
  2. Notifications
    1. [Feature Request] Remove notification related implementation #2086 Already removed in this issue
  3. Dynamic linking

Other

  1. You need to work on removing these functionalities from this repo and work with the contributors below to make sure the correct functionality occurs in the other repos.
  2. Documentation related to configuring these features needs to be removed as they will be no longer valid.
  3. Test code coverage needs to be maintained. Coverage for the PR patches needs to be 100%

The plan is to:

  • remove these features from the develop branch by commenting out the code.
  • merge the develop branch not containing these features into our master branch.
  • make the master branch the default

Please work with @Ayush0Chaudhary (Talawa impacts), @EshaanAgg & @xoldyckk (Talawa-API impacts) @beingnoble03 (Talawa-Admin impacts). Ask to be assigned this task by them.

Issues related to this one include:

@github-actions github-actions bot added documentation Update documentation test Testing application unapproved Unapproved, needs to be triaged labels Nov 16, 2023
@AyushRaghuvanshi
Copy link
Contributor

Hey, I would like to work on this. Can you please Assign me this one?

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Nov 17, 2023
@palisadoes
Copy link
Contributor Author

Please work with @Ayush0Chaudhary on this. He's worked extensively with this repo

@AyushRaghuvanshi
Copy link
Contributor

ohkay

@AyushRaghuvanshi
Copy link
Contributor

Hey, @Ayush0Chaudhary , so I just wanted to give a small plan of action. so that maybe you can double check and may be give some suggestions.
-> I would start with basically removing Chat_services file (commenting out) and then just comment out every unused or error occurring line.
But i suppose that would remove the whole chat feature. PR mentions we are supposed to remove Links to Chats does this mean this only? or m I on the wrong track?

@Ayush0Chaudhary
Copy link
Contributor

Ayush0Chaudhary commented Nov 18, 2023

Hey, @Ayush0Chaudhary , so I just wanted to give a small plan of action. so that maybe you can double check and may be give some suggestions.
-> I would start with basically removing Chat_services file (commenting out) and then just comment out every unused or error occurring line.
But i suppose that would remove the whole chat feature. PR mentions we are supposed to remove Links to Chats does this mean this only? or m I on the wrong track?

Chat removal is completed.

@AyushRaghuvanshi
Copy link
Contributor

AyushRaghuvanshi commented Nov 18, 2023

ok so i need to work on Dynamic Linking i suppose. Ill work on it, Thank you.

@Ayush0Chaudhary
Copy link
Contributor

ok so i need to work on Dynamic Linking i suppose. Ill work on it, Thank you.

Yes that is pending.
Is your setup complete?

@AyushRaghuvanshi
Copy link
Contributor

Yes, My set up is complete,

My Plan of action is to
-> remove all the share buttons.
-> remove Handle deep linking function from splash screen.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Nov 29, 2023
palisadoes pushed a commit that referenced this issue Nov 30, 2023
* Fix:Overflow Error on PostWideget

* Remove:Unused Hive Boxes

* Fix:Responsiveness on Icons

* Removed:dynamic Linking

* Fix:Not Changing unauthorized files

* Added:Documentation

* Removed: Empty test

* Modified:Test File name

* Add:Tests for misses

* Revert: removal of qr code

* Fix:Splash bug

* Fix:Format

* Fix:Failing test
palisadoes pushed a commit to palisadoes/talawa that referenced this issue Jan 10, 2024
* Fix:Overflow Error on PostWideget

* Remove:Unused Hive Boxes

* Fix:Responsiveness on Icons

* Removed:dynamic Linking

* Fix:Not Changing unauthorized files

* Added:Documentation

* Removed: Empty test

* Modified:Test File name

* Add:Tests for misses

* Revert: removal of qr code

* Fix:Splash bug

* Fix:Format

* Fix:Failing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Update documentation feature request no-issue-activity No issue activity test Testing application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants