Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP - Talawa Admin #1069

Closed
palisadoes opened this issue Nov 16, 2023 · 7 comments · Fixed by #1078
Closed

MVP - Talawa Admin #1069

palisadoes opened this issue Nov 16, 2023 · 7 comments · Fixed by #1078
Assignees
Labels
documentation Improvements or additions to documentation feature request

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Nov 16, 2023

We need to have an Talawa MVP by the end of the year. The MVP will be the master branch. To do this we will need to remove features that either don’t work or have insufficient functionality.

The features to remove include:

  1. Links to chat
  2. Notifications
  3. Dynamic linking

Other

  1. You need to work on removing these functionalities from this repo and work with the contributors below to make sure the correct functionality occurs in the other repos.
  2. Documentation related to configuring these features needs to be removed as they will be no longer valid.
  3. Test code coverage needs to be maintained. Coverage for the PR patches needs to be 100%

The plan is to:

  • remove these features from the develop branch by commenting out the code.
  • merge the develop branch not containing these features into our master branch.
  • make the master branch the default

Please work with @Ayush0Chaudhary (Talawa impacts), @EshaanAgg & @xoldyckk (Talawa-API impacts) @beingnoble03 (Talawa-Admin impacts). Ask to be assigned this task by them.

Issues related to this one include:

@github-actions github-actions bot added documentation Improvements or additions to documentation test Testing application unapproved labels Nov 16, 2023
@palisadoes palisadoes removed the test Testing application label Nov 17, 2023
@duplixx
Copy link
Member

duplixx commented Nov 17, 2023

Hey @Ayush0Chaudhary I can work with you in this milestone, Please let me know if you have any specific guidelines or instructions for this process.

@palisadoes
Copy link
Contributor Author

@duplixx Please work with @beingnoble03 on this. He is very familiar with this repo.

@duplixx
Copy link
Member

duplixx commented Nov 17, 2023

@palisadoes sure, hey @beingnoble03 please let me know if you have any specific instructions regarding the milestone.
Thanks!!

@duplixx
Copy link
Member

duplixx commented Nov 17, 2023

Hey @beingnoble03 ,
I've made progress on the removal of the dynamic linking to the chat section. I've commented out the relevant code and ensured that test coverage is maintained.

Regarding the notification functionality, could you please clarify what specific notifications are being referred to? Is it related to user notifications, system alerts, or something else?

@noman2002
Copy link
Member

@duplixx Comment out the notification which uses firebase i.e. user notification.

@duplixx
Copy link
Member

duplixx commented Nov 19, 2023

@palisadoes @noman2002
All Talawa-Admin features are complete, except for user notifications. After an in-depth search, it seems this feature
isn't talawa-admin repo.

Remove

  • Links to chat
  • Dynamic linking

image
image
image

@palisadoes
Copy link
Contributor Author

palisadoes commented Nov 19, 2023

@duplixx Thanks for that insight. Please proceed with the relevant PRs for this issue so that we can get the MVP live in the coming days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants