Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP - Talawa API #1427

Closed
palisadoes opened this issue Nov 16, 2023 · 15 comments
Closed

MVP - Talawa API #1427

palisadoes opened this issue Nov 16, 2023 · 15 comments
Assignees
Labels
documentation Improvements or additions to documentation feature request no-issue-activity No issue activity test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Nov 16, 2023

This is a parent issue for tracking purposes

We need to have an Talawa MVP by the end of the year. The MVP will be the master branch. To do this we will need to remove features that either don’t work or have insufficient functionality.

The features to remove include:

  1. Links to chat (Handled by PR)
    1. commented firebase notification code #1503
  2. Notifications (Handled by PR)
    1. commented firebase notification code #1503
  3. Dynamic linking (Handled by issue)
    1. Remove Dynamic Linking (MVP Prerequisite) #1510

Other

  1. You need to work on removing these functionalities from this repo and work with the contributors below to make sure the correct functionality occurs in the other repos.
  2. Documentation related to configuring these features needs to be removed as they will be no longer valid.
  3. Test code coverage needs to be maintained. Coverage for the PR patches needs to be 100%

The plan is to:

  • remove these features from the develop branch by commenting out the code.
  • merge the develop branch not containing these features into our master branch.
  • make the master branch the default

Please work with @Ayush0Chaudhary (Talawa impacts), @kb-0311 & @xoldyckk (Talawa-API impacts) @beingnoble03 (Talawa-Admin impacts). Ask to be assigned this task by them.
Issues related to this one include:

@github-actions github-actions bot added documentation Improvements or additions to documentation test Testing application unapproved Unapproved for Pull Request labels Nov 16, 2023
@kirtanchandak
Copy link

@Ayush0Chaudhary I can take this task

@palisadoes
Copy link
Contributor Author

  1. It may be sufficient to remove access to the features in the Talawa-Mobile MVP and Talawa-Admin MVP PRs alone to achieve this goal.
  2. Please work with @kb-0311 & @xoldyckk on this. Though the features mentioned don't work, we may want to leave the API code unchanged so that further work can be done on the features to make them really work.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Nov 28, 2023
@palisadoes
Copy link
Contributor Author

Unassigning due to inactivity and no submitted PR

@github-actions github-actions bot removed the no-issue-activity No issue activity label Nov 29, 2023
@zakhaev26
Copy link

zakhaev26 commented Nov 29, 2023

Can i please be assigned this issue @kb-0311 @Ayush0Chaudhary @xoldyckk @beingnoble03 ? I am currently learning the codebase and would like to contribute in it!

@punitkr03
Copy link

Hey @Ayush0Chaudhary @kb-0311 @xoldyckk @beingnoble03, I can work with @zakhaev26 (classmates) and can contribute to this issue. Can you please assign this issue to both of us?

@noman2002
Copy link
Member

@punitkr03 One person per issue.

@palisadoes
Copy link
Contributor Author

@zakhaev26 The features are to be disabled in Talawa and Talawa-Admin.

  1. We are planning on using locally generated notifications, so this feature should be disabled in the API if it supports it in any way.
  2. Similarly, we decided to disable deep linking, so this feature should be disabled in the API if it supports it in any way.
  3. Though we are removing chat functionality from Talawa and Talawa-Admin, it will most likely be restored during GSoC 2024 but in a much less buggy way. We'll need to keep this functionality in the API. DO NOT REMOVE CHAT FUNCTIONALITY

Please confirm that you understand this.

@zakhaev26
Copy link

zakhaev26 commented Dec 2, 2023

Sure,Currently having exams;will be working on it as soon as possible.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 17, 2023
@palisadoes
Copy link
Contributor Author

Unassigning due to no activity and no PRs

@palisadoes
Copy link
Contributor Author

Please work with the following persons to get this implemented

  1. @Ayush0Chaudhary
  2. @EshaanAgg
  3. @kb-0311

@github-actions github-actions bot removed the no-issue-activity No issue activity label Dec 18, 2023
@ayan-joshi
Copy link

Can I work on this issue , can u assign it to me @palisadoes ?

@palisadoes
Copy link
Contributor Author

Assigning to @EshaanAgg as he's overseeing the API MVP effort. This is a parent issue.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 29, 2023
@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Talawa-API (Tests) Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature request no-issue-activity No issue activity test Testing application
Projects
Archived in project
Development

No branches or pull requests

7 participants