Fixes MVP - Talawa #2108 #2114

AyushRaghuvanshi · 2023-11-18T22:14:12Z

What kind of change does this PR introduce?

This PR removes all usage of dyanmic linking. Including Sharing Links and creating QR

Issue Number:

Did you add tests for your changes?
No, It wasn't relevant.

Summary
#2108 asks to remove three features to make app MVP ready. upon discussion with @Ayush0Chaudhary it was come to conclusion that Chat and notification is already removed.

Hence this PR removes dynamic Linking as well

Does this PR introduce a breaking change?
No

Have you read the contributing guide?
Yes

…into overflowError

…into mvp

github-actions · 2023-11-18T22:14:41Z

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

The overall code coverage drops below the target threshold of the repository
Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

comments in this PR or
our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

arbitrators of future discussions with other contributors about the validity of your changes
point of contact for evaluating the validity of your work
person who verifies matching issues by others that should be closed.
person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

codecov · 2023-11-18T23:15:03Z

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (c253cb1) 79.85% compared to head (3ad67aa) 79.90%.

Files	Patch %	Lines
...views/after_auth_screens/profile/profile_page.dart	0.00%	10 Missing ⚠️
lib/splash_screen.dart	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2114      +/-   ##
===========================================
+ Coverage    79.85%   79.90%   +0.05%     
===========================================
  Files          152      149       -3     
  Lines         7456     6973     -483     
===========================================
- Hits          5954     5572     -382     
+ Misses        1502     1401     -101

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AyushRaghuvanshi · 2023-11-19T20:37:49Z

@Ayush0Chaudhary Can you once check if thats all I am required to comment out?

Few Extra changes involves Writing documentations and tests

Ayush0Chaudhary · 2023-11-19T22:26:21Z

We can use QR to produce link that lead to our playstore app.

What do you think @noman2002 ?

noman2002 · 2023-11-20T06:18:27Z

@Ayush0Chaudhary Yes we can do that but currently we don't have it on playstore.
@palisadoes Your thoughts on this? Should we keep the QR or remove it.

AyushRaghuvanshi · 2023-11-20T20:00:22Z

Hey @noman2002 @Ayush0Chaudhary , If my opinion is welcomed, I would like to also propose that ,

Provided we don't have Playstore link., for the time being we can use our github releases link.

Also we enable invite feature to invite people through social media but rather than using dynamic linking , we craft a message like
Hey, I invite you to install this app and join <Organization Name> .

I think it would be a good alternative for the time being.

palisadoes · 2023-11-20T20:51:14Z

We won't have an App Store presence for the MVP. We don't have a strategy on how to handle incompatibilities between different versions of the mobile app, API and Admin. We'll need one by the middle of next year.

It's best to have a link to the repo. @DMills27 is working on creating an issue that would help finalize where that location would be.

For the purposes of the MVP I'd comment out the QR code code and then reinsert it when we have the definitive link. It'll probably change with each release prior to having an app store presence.

Is there a way to embed a QR code in the repo so that people download the latest to their phone?

AyushRaghuvanshi · 2023-11-21T01:48:19Z

https://github.com/PalisadoesFoundation/talawa/releases/download/automated/app-release.apk

@palisadoes
Something like this?

if we create a QR for this link. It will automatically download the latest build to their mobile phones.

For Example.

palisadoes · 2023-11-21T02:22:02Z

Thanks. I meant could we also embed it in a markdown file on GitHub to make it easier for the development community?

README.md for example, but do so in an automated way so that the QR code in the master branch and develop branches download the appropriate APK.

AyushRaghuvanshi · 2023-11-22T07:17:19Z

I think we can do that by creating two readme files for each branch.

Creating a single Readme file and adding a placeholder is mentioned in this issue which is basically seems like not implemented as of now.

I think best approach would be to create two readme.md for each branch......

Also what does this mean about this PR? Is it alright?

palisadoes · 2023-11-23T02:00:45Z

@AyushRaghuvanshi Keep the QR code. Link to the APK in a way that matches the correct branch, if that is possible. If it's manual, then the resulting test should verify the branch is correct.

Let us know when that is complete so we can give it a final review before merging.

Is there anything in these files that need to be updated because of the disabled code?

README.md
CONTRIBUTING.md
INSTALLATION.md
Other markdown files?

palisadoes · 2023-11-23T02:39:22Z

@AyushRaghuvanshi have you commented out any unused packages in pubspec.yaml
We don't want to be receiving unnecessary security alerts

AyushRaghuvanshi · 2023-11-23T10:34:53Z

@Ayush0Chaudhary @noman2002 Don't merge this yet. I am still working on the changes @palisadoes recommended.

noman2002 · 2023-11-25T09:54:58Z

@AyushRaghuvanshi What are the updates on this one? We need to merge this.

AyushRaghuvanshi · 2023-11-25T10:31:36Z

@noman2002 I have made the package version changes. I was researching a lot if i can automate a process where we get QR code according to the branch.

I think we can set up a .env file as well? and in the installation.md we state that to access QR code you need to add the correct branch release link

@palisadoes How does that sound?

noman2002 · 2023-11-25T10:56:59Z

@AyushRaghuvanshi I don't think it will work. It will make things more complex. I suggest we can just redirect the qr to master branch. There no need to redirect it to develop branch.
@palisadoes Your thoughts on this ?

palisadoes · 2023-11-25T15:20:45Z

The QR code should be for the main branch. Please make the modification

noman2002

Looks good to me.
@Ayush0Chaudhary Please have a look.

palisadoes · 2023-11-28T19:09:42Z

@AyushRaghuvanshi What version of the API were you using to test against? What commit were you working with? @Ayush0Chaudhary is working on the main migration with another PR.

AyushRaghuvanshi · 2023-11-29T14:49:23Z

@palisadoes I have the latest pull of the talawa-api repo.

palisadoes · 2023-11-29T15:03:12Z

@palisadoes I have the latest pull of the talawa-api repo.

Thanks @AyushRaghuvanshi . Are you also up to date with all merged PRs, especially this one?

Upgrading flutter to the latest stable version v3.16.0 #2140

@kb-0311 @Ayush0Chaudhary This may greatly assist your cross repo MVP goal and the eventual compatibility check.

…into mvp

AyushRaghuvanshi · 2023-11-29T15:13:27Z

@palisadoes I wasn't. But Now I am with my latest push.

palisadoes · 2023-11-29T15:15:47Z

Please fix the failing tests.

palisadoes · 2023-11-29T17:29:09Z

@noman2002 @Ayush0Chaudhary Please review and merge if OK.

* Fix:Overflow Error on PostWideget * Remove:Unused Hive Boxes * Fix:Responsiveness on Icons * Removed:dynamic Linking * Fix:Not Changing unauthorized files * Added:Documentation * Removed: Empty test * Modified:Test File name * Add:Tests for misses * Revert: removal of qr code * Fix:Splash bug * Fix:Format * Fix:Failing test

AyushRaghuvanshi added 7 commits November 15, 2023 00:40

Fix:Overflow Error on PostWideget

8a6aefb

Merge branch 'develop' of https://github.com/AyushRaghuvanshi/talawa …

1f7c71e

…into overflowError

Remove:Unused Hive Boxes

1beda84

Fix:Responsiveness on Icons

ae05a77

Removed:dynamic Linking

b5044de

Merge branch 'develop' of https://github.com/AyushRaghuvanshi/talawa …

178ffd6

…into mvp

Fix:Not Changing unauthorized files

a727b2d

AyushRaghuvanshi added 2 commits November 19, 2023 04:29

Added:Documentation

bb043c5

Removed: Empty test

b48e73d

AyushRaghuvanshi force-pushed the mvp branch from c37e036 to b48e73d Compare November 19, 2023 18:38

AyushRaghuvanshi added 2 commits November 20, 2023 00:52

Modified:Test File name

e9ebd3d

Add:Tests for misses

3bcaf22

palisadoes requested review from Ayush0Chaudhary and noman2002 November 19, 2023 21:55

Ayush0Chaudhary previously approved these changes Nov 22, 2023

View reviewed changes

noman2002 previously approved these changes Nov 23, 2023

View reviewed changes

Revert: removal of qr code

fb9a716

AyushRaghuvanshi dismissed stale reviews from noman2002 and Ayush0Chaudhary via fb9a716 November 27, 2023 20:18

noman2002 previously approved these changes Nov 28, 2023

View reviewed changes

noman2002 requested a review from Ayush0Chaudhary November 28, 2023 05:42

Fix:Splash bug

34fb3e5

AyushRaghuvanshi dismissed noman2002’s stale review via 34fb3e5 November 29, 2023 14:50

Merge branch 'develop' of https://github.com/AyushRaghuvanshi/talawa …

05476cc

…into mvp

AyushRaghuvanshi added 2 commits November 29, 2023 21:10

Fix:Format

d031036

Fix:Failing test

3ad67aa

noman2002 approved these changes Nov 30, 2023

View reviewed changes

palisadoes approved these changes Nov 30, 2023

View reviewed changes

palisadoes merged commit 2f271ac into PalisadoesFoundation:develop Nov 30, 2023
6 of 7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes MVP - Talawa #2108 #2114

Fixes MVP - Talawa #2108 #2114

AyushRaghuvanshi commented Nov 18, 2023

github-actions bot commented Nov 18, 2023

codecov bot commented Nov 18, 2023 •

edited

Loading

AyushRaghuvanshi commented Nov 19, 2023

Ayush0Chaudhary commented Nov 19, 2023 •

edited

Loading

noman2002 commented Nov 20, 2023

AyushRaghuvanshi commented Nov 20, 2023

palisadoes commented Nov 20, 2023 •

edited

Loading

AyushRaghuvanshi commented Nov 21, 2023

palisadoes commented Nov 21, 2023

AyushRaghuvanshi commented Nov 22, 2023

palisadoes commented Nov 23, 2023 •

edited

Loading

palisadoes commented Nov 23, 2023

AyushRaghuvanshi commented Nov 23, 2023

noman2002 commented Nov 25, 2023

AyushRaghuvanshi commented Nov 25, 2023

noman2002 commented Nov 25, 2023

palisadoes commented Nov 25, 2023 •

edited

Loading

noman2002 left a comment •

edited

Loading

palisadoes commented Nov 28, 2023

AyushRaghuvanshi commented Nov 29, 2023

palisadoes commented Nov 29, 2023

AyushRaghuvanshi commented Nov 29, 2023

palisadoes commented Nov 29, 2023

palisadoes commented Nov 29, 2023

Fixes MVP - Talawa #2108 #2114

Fixes MVP - Talawa #2108 #2114

Conversation

AyushRaghuvanshi commented Nov 18, 2023

github-actions bot commented Nov 18, 2023

Our Pull Request Approval Process

Testing Your Code

Reviewers

Reviewing Your Code

Other

codecov bot commented Nov 18, 2023 • edited Loading

Codecov Report

AyushRaghuvanshi commented Nov 19, 2023

Ayush0Chaudhary commented Nov 19, 2023 • edited Loading

noman2002 commented Nov 20, 2023

AyushRaghuvanshi commented Nov 20, 2023

palisadoes commented Nov 20, 2023 • edited Loading

AyushRaghuvanshi commented Nov 21, 2023

palisadoes commented Nov 21, 2023

AyushRaghuvanshi commented Nov 22, 2023

palisadoes commented Nov 23, 2023 • edited Loading

palisadoes commented Nov 23, 2023

AyushRaghuvanshi commented Nov 23, 2023

noman2002 commented Nov 25, 2023

AyushRaghuvanshi commented Nov 25, 2023

noman2002 commented Nov 25, 2023

palisadoes commented Nov 25, 2023 • edited Loading

noman2002 left a comment • edited Loading

Choose a reason for hiding this comment

palisadoes commented Nov 28, 2023

AyushRaghuvanshi commented Nov 29, 2023

palisadoes commented Nov 29, 2023

AyushRaghuvanshi commented Nov 29, 2023

palisadoes commented Nov 29, 2023

palisadoes commented Nov 29, 2023

codecov bot commented Nov 18, 2023 •

edited

Loading

Ayush0Chaudhary commented Nov 19, 2023 •

edited

Loading

palisadoes commented Nov 20, 2023 •

edited

Loading

palisadoes commented Nov 23, 2023 •

edited

Loading

palisadoes commented Nov 25, 2023 •

edited

Loading

noman2002 left a comment •

edited

Loading