Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dynamic Linking (MVP Prerequisite) #1510

Closed
palisadoes opened this issue Dec 18, 2023 · 10 comments
Closed

Remove Dynamic Linking (MVP Prerequisite) #1510

palisadoes opened this issue Dec 18, 2023 · 10 comments
Assignees
Labels
documentation Improvements or additions to documentation feature request test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Dec 18, 2023

We need to have an Talawa MVP by the end of the year. The MVP will be the master branch. To do this we will need to remove features that either don’t work or have insufficient functionality.

The feature to remove include:

  1. Dynamic linking

Other

  1. You need to work on removing these functionalities from this repo and work with the contributors below to make sure the correct functionality occurs in the other repos.
  2. No other functionality must be removed
  3. Documentation related to configuring these features needs to be removed as they will be no longer valid.
  4. Test code coverage needs to be maintained. Coverage for the PR patches needs to be 100%

The plan is to:

  • remove these features from the develop branch by commenting out the code.

Please work with @Ayush0Chaudhary (Talawa impacts), @kb-0311 & @xoldyckk (Talawa-API impacts) @beingnoble03 (Talawa-Admin impacts). Ask to be assigned this task by them.
Issues related to this one include:

@github-actions github-actions bot added documentation Improvements or additions to documentation test Testing application unapproved Unapproved for Pull Request labels Dec 18, 2023
@Gmin2
Copy link

Gmin2 commented Dec 18, 2023

@EshaanAgg can i work in it?

@Veer0x1
Copy link
Contributor

Veer0x1 commented Dec 18, 2023

Would like to work on it.

@EshaanAgg
Copy link
Contributor

Assigned @Min2who as he asked first. If he is unable to make meaningful progress in a week's time, @Veer0x1 you can take up the issue.

@Cioppolo14 Cioppolo14 removed the unapproved Unapproved for Pull Request label Dec 19, 2023
@Gmin2
Copy link

Gmin2 commented Dec 23, 2023

@Veer0x1 go ahead?

@Gmin2 Gmin2 removed their assignment Dec 23, 2023
@AdityaRaimec22
Copy link
Contributor

@EshaanAgg can you please assign me this issue.

@AdityaRaimec22
Copy link
Contributor

@kb-0311 @xoldyckk Could you please assist me with this issue? I'm relatively new to Talawa and would appreciate guidance on how to proceed.

@AdityaRaimec22
Copy link
Contributor

AdityaRaimec22 commented Dec 26, 2023

@palisadoes I've thoroughly reviewed the talawa-api codebase and consulted with several contributors, but unfortunately, I couldn't gather substantial information about the issue. Can you provide further guidance on how I can resolve this issue?

@AdityaRaimec22 AdityaRaimec22 removed their assignment Dec 29, 2023
@Veer0x1
Copy link
Contributor

Veer0x1 commented Dec 30, 2023

I would like to work on it.

@Veer0x1
Copy link
Contributor

Veer0x1 commented Jan 8, 2024

@palisadoes I have asked @noman2002 about this, and he said the dynamic linking was done through firebase, and all firebase code has been already removed from the repo in this PR. I tried to find its resolver but I didn't found any. Can you tell me where in repo actually this functionality was implemented?

@palisadoes
Copy link
Contributor Author

Thanks, if that is the case, then we should close this issue.
Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature request test Testing application
Projects
None yet
Development

No branches or pull requests

6 participants