Migrate existing usages of fixup_yarn_lock with fixup-yarn-lock from prefetch-yarn-deps

[lilyinstarlight]

Issue description

This is a follow-up to #214062 to migrate existing packages which use fixup_yarn_lock (from yarn2nix) to fixup-yarn-lock (from prefetch-yarn-deps)

It should be a drop-in replacement, just by adding prefetch-yarn-deps to nativeBuildInputs and changing the fixup_yarn_lock invocation to fixup-yarn-lock

cc @NixOS/node

Packages to update

• muzika muzika: migrate to prefetch-yarn-deps #269323
• oni2 oni2: remove #269322
• drawio drawio: migrate to prefetch-yarn-deps #269321
• tandoor-recipes tandoor-recipes: migrate to prefetch-yarn-deps #269319
• element-desktop (and element-desktop.seshat) element-desktop: migrate to prefetch-yarn-deps #269318
• element-web element-web: migrate to prefetch-yarn-deps #269317
• schildichat-desktop schildichat-desktop: migrate to prefetch-yarn-deps #269315
• schildichat-web schildichat-web: migrate to prefetch-yarn-deps #269314
• teams-for-linux teams-for-linux: migrate to prefetch-yarn-deps #269312
• thelounge thelounge: migrate to prefetch-yarn-deps #269310
• gitlab gitlab: migrate to prefetch-yarn-deps #269307
• sapling sapling: migrate to prefetch-yarn-deps #269305
• podman-desktop podman-desktop: migrate to prefetch-yarn-deps #269304
• coder coder: migrate to prefetch-yarn-deps #269303/coder: 0.17.1 -> 2.9.1 #301512
• electron-fiddle electron-fiddle: migrate to prefetch-yarn-deps #269302
• anki anki: migrate to prefetch-yarn-deps #269301
• heroic heroic: migrate to prefetch-yarn-deps #269300
• r2modman r2modman: migrate to prefetch-yarn-deps #269299
• akkoma-frontends.admin-fe {akkoma,admin-fe}: Migrate to prefetch-yarn-deps #249954
• akkoma-frontends.akkoma-fe {akkoma,admin-fe}: Migrate to prefetch-yarn-deps #249954
• alice-lg alice-lg: migrate to prefetch-yarn-deps #269298
• mastodon mastodon: migrate to prefetch-yarn-deps #269295
• peertube peertube: migrate to prefetch-yarn-deps #269294
• rmfakecloud.ui rmfakecloud.ui: migrate to prefetch-yarn-deps #269293
• teleport teleport: migrate to prefetch-yarn-deps #269286
• discourse discourse: migrate to prefetch-yarn-deps #269287
• outline outline: migrate to prefetch-yarn-deps #269999
• pgadmin pgadmin: migrate to prefetch-yarn-deps #269276
• ratman ratman: migrate to prefetch-yarn-deps #269285
• tilt tilt: migrate to prefetch-yarn-deps #269885
• hydrogen-web hydrogen-web: migrate to prefetch-yarn-deps #269903
• python311Packages.dash python311Packages.dash: migrate to prefetch-yarn-deps #269907
• electron electron: migrate to prefetch-yarn-deps #269933
• redisinsight-electron redisinsight: fix build, refactor #307467
• gotify-server gotify-server: migrate to prefetch-yarn-deps #269873
• grafana-agent grafana-agent: migrate to prefetch-yarn-deps #269865
• insulator2 insulator2: 2.12.2 -> 2.13.2 #323882
• crabfit-frontend crabfit-frontend: migrate to fixup-yarn-lock #323883
• tetrio-desktop(specifically the tetrio-plus.nix file, as the package itself doesn't use it) tetrio-desktop: migrate to fixup-yarn-lock #323884

[Stunkymonkey]

I started doing the package docuseal which used fixup_yarn_lock (worked). When using the new "drop-in-method" (fixup-yarn-lock) i am getting:

/nix/store/ypig039xrfd6p355v3diy9avbs58zywj-yarn-1.22.19/libexec/yarn/lib/cli.js:2325
    throw error;
    ^

Invariant Violation: Commit hash required
    at invariant (/nix/store/ypig039xrfd6p355v3diy9avbs58zywj-yarn-1.22.19/libexec/yarn/lib/cli.js:2318:15)
    at Extract.<anonymous> (/nix/store/ypig039xrfd6p355v3diy9avbs58zywj-yarn-1.22.19/libexec/yarn/lib/cli.js:89267:11)
    at Extract.emit (node:events:529:35)
    at finishMaybe (/nix/store/ypig039xrfd6p355v3diy9avbs58zywj-yarn-1.22.19/libexec/yarn/lib/cli.js:74117:14)
    at /nix/store/ypig039xrfd6p355v3diy9avbs58zywj-yarn-1.22.19/libexec/yarn/lib/cli.js:74095:5
    at module.exports.Extract._final (/nix/store/ypig039xrfd6p355v3diy9avbs58zywj-yarn-1.22.19/libexec/yarn/lib/cli.js:151032:3)
    at callFinal (/nix/store/ypig039xrfd6p355v3diy9avbs58zywj-yarn-1.22.19/libexec/yarn/lib/cli.js:74088:10)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  framesToPop: 1
}

I did it the same way the other two PRs were done. Any idea?

[lilyinstarlight]

It seems to be due to yarn not liking missing a commit hash in both the resolved URL and version spec here: https://github.com/docusealco/docuseal/blob/3c69430b947c1c1ea61e25ad9275b14df005a3c7/package.json#L10

I've got a fix for fixup-yarn-lock that I'll PR imminently

[Stunkymonkey]

@lilyinstarlight what about the following files? they use the fixup_yarn_lock as well:

• pkgs/applications/networking/cluster/tilt/assets.nix
• pkgs/applications/networking/instant-messengers/hydrogen-web/unwrapped.nix
• pkgs/development/python-modules/dash/default.nix
• pkgs/development/tools/electron/common.nix
• pkgs/development/tools/redisinsight/default.nix
• pkgs/servers/gotify/ui.nix
• pkgs/servers/monitoring/grafana-agent/default.nix

should these be added at the top?

[lilyinstarlight]

should these be added at the top?

Yeah, I imagine they didn't use it at the time I made this tracking issue (also wow are there a lot of open PRs now!)

Feel free to edit them in yourself or I'll get around to it when I have some time to get through some of these, thank you so much! :)

[TomaSajt]

I'll try to rework the redisinsight derivation, 'cuz I think it was broken to begin with.

[SuperSandro2000]

It should be a drop-in replacement, just by adding prefetch-yarn-deps to nativeBuildInputs and changing the fixup_yarn_lock invocation to fixup-yarn-lock

I have encountered one issue with that. fixup-yarn-lock has an extra dependency on nix-prefetch-git and through that git-lfs which busted a cache for me because I update my standard golang compiler. Is there a possibility to reduce the dependencies of prefetch-yarn-deps/nix-prefetch-git?

[SuperSandro2000]

I did a POC with that in #281902 which I still need to validate.

[Stunkymonkey]

currently only redisinsight is missing (currently failing on master). The rest is migrated. Do we keep this issue open?

[lilyinstarlight]

currently only redisinsight is missing (currently failing on master). The rest is migrated. Do we keep this issue open?

If it's all done, I'm happy for it to be closed :)

Thank you for all of the work <3

[codingCoffee]

Hey, came across this issue while trying to install the redisinsight package. The installation still seems to be broken, is there any temporary workaround for installing it?

[pyrox0]

Packages that haven't been migrated:

• insulator2 insulator2: 2.12.2 -> 2.13.2 #323882
• crabfit-frontend crabfit-frontend: migrate to fixup-yarn-lock #323883
• tetrio-desktop(specifically the tetrio-plus.nix file, as the package itself doesn't use it) tetrio-desktop: migrate to fixup-yarn-lock #323884

Would there be a way/an incentive to disallow new packages from using fixup_yarn_lock? Alternatively, once all usages of it are removed from the tree, is there any reason to keep it around? If there is a reason, should there be a deprecation notice added when fixup_yarn_lock is used?

[Stunkymonkey]

@pyrox0 thanks. added them to the list with the MRs.