Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oni2: remove #269322

Merged
merged 1 commit into from
Jan 16, 2024
Merged

oni2: remove #269322

merged 1 commit into from
Jan 16, 2024

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Nov 22, 2023 •
edited
Loading

Description of changes

#240174

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@Stunkymonkey Stunkymonkey mentioned this pull request Nov 22, 2023
Closed
39 tasks
@ofborg ofborg bot requested a review from gardspirito November 23, 2023 03:54
@Stunkymonkey Stunkymonkey requested review from lilyinstarlight and removed request for lilyinstarlight December 3, 2023 10:55
@teto
Copy link
Member

teto commented Dec 3, 2023

Result of nixpkgs-review pr 269322 run on x86_64-linux 1

1 package marked as broken and skipped:
  • oni2

@teto
Copy link
Member

teto commented Jan 15, 2024

Let's dump oni2 it's unmaintained, last commit 3 years ago

@Stunkymonkey Stunkymonkey changed the title oni2: migrate to prefetch-yarn-deps oni2: remove Jan 15, 2024
@Stunkymonkey Stunkymonkey force-pushed the oni2-migrate-prefetch-yarn-deps branch from 19f2aa5 to 73d5bd3 Compare January 15, 2024 19:27
@Stunkymonkey Stunkymonkey requested a review from teto January 15, 2024 19:28
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Jan 16, 2024
@teto teto merged commit d38b8bd into NixOS:master Jan 16, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gardspirito gardspirito Awaiting requested review from gardspirito

@teto teto Awaiting requested review from teto

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stunkymonkey @teto