Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.dash: migrate to prefetch-yarn-deps #269907

Conversation

Stunkymonkey
Copy link
Contributor

Description of changes

#240174

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 25, 2023
@Stunkymonkey
Copy link
Contributor Author

Result of nixpkgs-review pr 269907 run on x86_64-linux 1

8 packages built:
  • das
  • das.dist
  • picosnitch
  • picosnitch.dist
  • python310Packages.dash
  • python310Packages.dash.dist
  • python311Packages.dash
  • python311Packages.dash.dist

@Stunkymonkey Stunkymonkey merged commit b9ff1de into NixOS:master Nov 25, 2023
5 checks passed
@Stunkymonkey Stunkymonkey deleted the python311Packages.dash-migrate-prefetch-yarn-deps branch November 25, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants