Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

anki: migrate to prefetch-yarn-deps #269301

Merged
merged 1 commit into from
Nov 25, 2023
Merged

anki: migrate to prefetch-yarn-deps #269301

merged 1 commit into from
Nov 25, 2023

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Nov 22, 2023 •
edited
Loading

Description of changes

#240174

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@Stunkymonkey Stunkymonkey mentioned this pull request Nov 22, 2023
Closed
39 tasks
@ofborg ofborg bot requested review from oxij, euank and paveloom November 23, 2023 02:20
paveloom
paveloom reviewed Nov 23, 2023
View reviewed changes
Copy link
Member

@paveloom paveloom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#269010 seems unrelated. I guess you meant to link to #240174.

Works fine. Testing yourself would be appreciated, of course.

Please sort alphabetically the second block of the inputs at the top, and the first block in both nativeBuildInputs.

@Stunkymonkey Stunkymonkey removed the request for review from oxij November 23, 2023 21:41
@Stunkymonkey Stunkymonkey force-pushed the anki-migrate-prefetch-yarn-deps branch from 119a926 to 1e91f0d Compare November 23, 2023 21:44
@Stunkymonkey
Copy link
Contributor Author

thanks @paveloom for your suggestions. Applied them. (and corrected the link in the description; somehow messed that up)

@ofborg ofborg bot requested review from paveloom and oxij November 23, 2023 23:50
@paveloom
Copy link
Member

Please sort alphabetically the first block in both nativeBuildInputs, too.

@Stunkymonkey
Copy link
Contributor Author

sorry. should be fixed now.

@Stunkymonkey Stunkymonkey force-pushed the anki-migrate-prefetch-yarn-deps branch from 1e91f0d to e6f8708 Compare November 25, 2023 02:05
@paveloom
Copy link
Member

Please sort alphabetically the first block of the second nativeBuildInputs, too:

https://github.com/Stunkymonkey/nixpkgs/blob/e6f87087810b8b2252676fbaf0ced81b8693cd6c/pkgs/games/anki/default.nix#L136-L139

@Stunkymonkey Stunkymonkey force-pushed the anki-migrate-prefetch-yarn-deps branch from e6f8708 to 9d1029f Compare November 25, 2023 11:31
@Stunkymonkey
Copy link
Contributor Author

hopefully I now got everything.

euank
euank approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@euank euank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@ofborg ofborg bot requested review from euank and paveloom November 25, 2023 14:58
@Stunkymonkey Stunkymonkey merged commit d9229ab into NixOS:master Nov 25, 2023
8 of 9 checks passed
@Stunkymonkey Stunkymonkey deleted the anki-migrate-prefetch-yarn-deps branch November 25, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxij oxij Awaiting requested review from oxij

@euank euank Awaiting requested review from euank

@paveloom paveloom Awaiting requested review from paveloom

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stunkymonkey @paveloom @euank