Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

heroic: migrate to prefetch-yarn-deps #269300

Merged
merged 1 commit into from
Nov 25, 2023
Merged

heroic: migrate to prefetch-yarn-deps #269300

merged 1 commit into from
Nov 25, 2023

Conversation

Stunkymonkey
Copy link
Contributor

@Stunkymonkey Stunkymonkey commented Nov 22, 2023 •
edited
Loading

Description of changes

#240174

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@Stunkymonkey Stunkymonkey mentioned this pull request Nov 22, 2023
Closed
39 tasks
@ofborg ofborg bot requested a review from aidalgol November 23, 2023 01:56
aidalgol
aidalgol approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@aidalgol aidalgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. I can't test this, because nix on my system wants to build Electron for some reason, so I'm going to trust that prefetch-yarn-deps has been tested sufficiently that if heroic still builds, then it's safe to merge.

@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 23, 2023
@Stunkymonkey
Copy link
Contributor Author

Result of nixpkgs-review pr 269300 run on x86_64-linux 1

2 packages built:
  • heroic
  • heroic-unwrapped

@Stunkymonkey Stunkymonkey merged commit 1ec2460 into NixOS:master Nov 25, 2023
15 checks passed
@Stunkymonkey Stunkymonkey deleted the heroic-migrate-prefetch-yarn-deps branch November 25, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidalgol aidalgol aidalgol approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stunkymonkey @aidalgol @delroth