Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement to crankcase heater #9949

Merged
merged 76 commits into from
Aug 17, 2023
Merged

Enhancement to crankcase heater #9949

merged 76 commits into from
Aug 17, 2023

Commits on Apr 11, 2023

  1. initial commit

    @yujiex
    yujiex committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    106674e View commit details
    Browse the repository at this point in the history

  2. correct typo

    @yujiex
    yujiex committed Apr 11, 2023
    5 Configuration menu
    Copy the full SHA
    6e81025 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2023

  1. Merge remote-tracking branch 'origin/develop' into crankcaseHeater

    @yujiex
    yujiex committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    64441fa View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Initial commmit of test file idf

    @yujiex
    yujiex committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    e276e35 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. idd change, input reading and test for Coil:Cooling/Heating:DX

    @yujiex
    yujiex committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    b3be8f3 View commit details
    Browse the repository at this point in the history

  2. Fix unit test

    @yujiex
    yujiex committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    bbfdc1e View commit details
    Browse the repository at this point in the history

  3. idd change, input reading and testing of Coil:WaterHeating:AWHP

    @yujiex
    yujiex committed Apr 26, 2023
    5 Configuration menu
    Copy the full SHA
    636e83c View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. clang-format

    @yujiex
    yujiex committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    b0dab74 View commit details
    Browse the repository at this point in the history

  2. add testfile to CMakeLists.txt

    @yujiex
    yujiex committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    b9ce8b3 View commit details
    Browse the repository at this point in the history

  3. Apply crankcase heater capacity curve to DXCoils

    @yujiex
    yujiex committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    9db1960 View commit details
    Browse the repository at this point in the history

  4. Apply crankcase heater curve to variable speed coils

    @yujiex
    yujiex committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    544b35d View commit details
    Browse the repository at this point in the history

  5. Initial commit of tesetfile variableSpeedCoil crankcaseheater curve

    @yujiex
    yujiex committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    ad30083 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Modify testfiles

    @yujiex
    yujiex committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    136a3d7 View commit details
    Browse the repository at this point in the history

  2. add explicit return to unit test

    @yujiex
    yujiex committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    244c788 View commit details
    Browse the repository at this point in the history

  3. Change curve field name to match existing pattern

    @yujiex
    yujiex committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    b9e2903 View commit details
    Browse the repository at this point in the history

  4. add curve validation

    @yujiex
    yujiex committed Apr 28, 2023
    2 Configuration menu
    Copy the full SHA
    a334a7d View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Merge remote-tracking branch 'origin/develop' into crankcaseHeater

    @yujiex
    yujiex committed May 4, 2023
    Configuration menu
    Copy the full SHA
    b113828 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Use the same temperature var for the curve and threshold

    @yujiex
    yujiex committed May 25, 2023
    Configuration menu
    Copy the full SHA
    2864dcd View commit details
    Browse the repository at this point in the history

  2. Add end of file new line

    @yujiex
    yujiex committed May 25, 2023
    Configuration menu
    Copy the full SHA
    37da88c View commit details
    Browse the repository at this point in the history

  3. Add unit tests for applying the heater capacity curve

    @yujiex
    yujiex committed May 25, 2023
    Configuration menu
    Copy the full SHA
    752e761 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/develop' into crankcaseHeater

    @yujiex
    yujiex committed May 25, 2023
    5 Configuration menu
    Copy the full SHA
    ffb6e67 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. update doc

    @yujiex
    yujiex committed May 26, 2023
    Configuration menu
    Copy the full SHA
    0b16e03 View commit details
    Browse the repository at this point in the history

  2. fix idf and tests from idd change in merged develop

    @yujiex
    yujiex committed May 26, 2023
    5 Configuration menu
    Copy the full SHA
    5240550 View commit details
    Browse the repository at this point in the history

  3. clang-format

    @yujiex
    yujiex committed May 26, 2023
    5 Configuration menu
    Copy the full SHA
    c577a8d View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. add comments to unit test

    @yujiex
    yujiex committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    717a341 View commit details
    Browse the repository at this point in the history

  2. Add heater curve code in Coil:Cooling:DX:CurveFit:Performance

    @yujiex
    yujiex committed Jun 1, 2023
    5 Configuration menu
    Copy the full SHA
    f624b7b View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Merge remote-tracking branch 'origin/develop' into crankcaseHeater

    @yujiex
    yujiex committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    0dbfbf1 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Change to normalized curve

    @yujiex
    yujiex committed Jun 7, 2023
    5 Configuration menu
    Copy the full SHA
    031db77 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. move curve to front, Coil:Cooling:DX:SingleSpeed

    @yujiex
    yujiex committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    ae2b746 View commit details
    Browse the repository at this point in the history

  2. move curve to front, Coil:Cooling:DX:MultiSpeed

    @yujiex
    yujiex committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    b69db40 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. move coil to front, Coil:Heating:DX:SingleSpeed

    @yujiex
    yujiex committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    e85c813 View commit details
    Browse the repository at this point in the history

  2. adjust > NumAlphas threshold for Cooling:DX:SingleSpeed

    @yujiex
    yujiex committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    fa4332e View commit details
    Browse the repository at this point in the history

  3. adjust NumAlphas threshold in Coil:Cooling:DX:MultiSpeed

    @yujiex
    yujiex committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    e75f68c View commit details
    Browse the repository at this point in the history

  4. move curve to front, Coil:Heating:DX:MultiSpeed

    @yujiex
    yujiex committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    1cbb8c3 View commit details
    Browse the repository at this point in the history

  5. move curve to front, Coil:Cooling:DX:TwoStageWithHumidityControlMode

    @yujiex
    yujiex committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    481df18 View commit details
    Browse the repository at this point in the history

  6. move curve to front, Coil:WaterHeating:AirToWaterHeatPump:Pumped

    @yujiex
    yujiex committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    a79d2d0 View commit details
    Browse the repository at this point in the history

  7. move curve to front Coil:WaterHeating:AirToWaterHeatPump:Wrapped

    @yujiex
    yujiex committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    46f7f24 View commit details
    Browse the repository at this point in the history

  8. move curve to front, Coil:Cooling:DX:VariableSpeed

    @yujiex
    yujiex committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    17a8fca View commit details
    Browse the repository at this point in the history

  9. move curve to front, Coil:Heating:DX:VariableSpeed

    @yujiex
    yujiex committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    8a500fc View commit details
    Browse the repository at this point in the history

  10. move curve to front, Coil:WaterHeating:AirToWaterHeatPump:VariableSpeed

    @yujiex
    yujiex committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    59175e5 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2023

  1. move curve to front, Coil:Cooling:DX:CurveFit:Performance

    @yujiex
    yujiex committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    90fffbd View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. fix testfile .idf with inserted field

    @yujiex
    yujiex committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    f8a0cb8 View commit details
    Browse the repository at this point in the history

  2. fix unit test with added field

    @yujiex
    yujiex committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    7adea4b View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/develop' into crankcaseHeater

    @yujiex
    yujiex committed Jun 13, 2023
    5 Configuration menu
    Copy the full SHA
    610312b View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. fix WaterThermalTanks unit test

    @yujiex
    yujiex committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    0a0e9f0 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into crankcaseHeater

    @yujiex
    yujiex committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    e7b7b0f View commit details
    Browse the repository at this point in the history

  3. add new field to the expand object epfilter.f90

    @yujiex
    yujiex committed Jun 14, 2023
    5 Configuration menu
    Copy the full SHA
    0cce1b6 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. try fixing long string

    @yujiex
    yujiex committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    de06e01 View commit details
    Browse the repository at this point in the history

  2. clang-format

    @yujiex
    yujiex committed Jun 15, 2023
    5 Configuration menu
    Copy the full SHA
    4c0d6d4 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. fix idf raw string issue

    @yujiex
    yujiex committed Jun 16, 2023
    5 Configuration menu
    Copy the full SHA
    d81a5d0 View commit details
    Browse the repository at this point in the history

  2. clang-format

    @yujiex
    yujiex committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    e3fc4f9 View commit details
    Browse the repository at this point in the history

  3. add transition code

    @yujiex
    yujiex committed Jun 16, 2023
    5 Configuration menu
    Copy the full SHA
    b0bf50a View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/develop' into crankcaseHeater

    @yujiex
    yujiex committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    e34a6fe View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. unify input field name 

    it might need to be different in the future, but that will be taken care of in a
separate branch
    @yujiex
    yujiex committed Jun 20, 2023
    5 Configuration menu
    Copy the full SHA
    3060af4 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Merge remote-tracking branch 'remotes/origin/develop' into crankcaseH… 

    …eater
    @mjwitte
    mjwitte committed Jul 21, 2023
    5 Configuration menu
    Copy the full SHA
    20de981 View commit details
    Browse the repository at this point in the history

  2. field name change to Crankcase Heater Capacity Function of ...

    @yujiex
    yujiex committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    cb18d93 View commit details
    Browse the repository at this point in the history

  3. idd increment min-field by 1 for new field within min-field

    @yujiex
    yujiex committed Jul 21, 2023
    4 Configuration menu
    Copy the full SHA
    17cfbdf View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. fix Cooling:DX:VariableSpeed version transition

    @yujiex
    yujiex committed Jul 24, 2023
    5 Configuration menu
    Copy the full SHA
    baed7f9 View commit details
    Browse the repository at this point in the history

  2. Revert "fix Cooling:DX:VariableSpeed version transition" 

    This reverts commit baed7f9.
    @yujiex
    yujiex committed Jul 24, 2023
    5 Configuration menu
    Copy the full SHA
    38270b6 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. fix variable speed coil transition increment CurArgs

    @yujiex
    yujiex committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    0780657 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into crankcaseHeater

    @yujiex
    yujiex committed Jul 26, 2023
    5 Configuration menu
    Copy the full SHA
    5f02a7d View commit details
    Browse the repository at this point in the history

  3. reduce min-fields Cooling:DX:MultiSpeed (limit to 2 spd)

    @yujiex
    yujiex committed Jul 26, 2023
    5 Configuration menu
    Copy the full SHA
    6358b58 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Merge remote-tracking branch 'origin/develop' into crankcaseHeater

    @yujiex
    yujiex committed Jul 27, 2023
    5 Configuration menu
    Copy the full SHA
    ec1f908 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Fix unit test after merging

    @yujiex
    yujiex committed Jul 28, 2023
    5 Configuration menu
    Copy the full SHA
    d6607cd View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Merge remote-tracking branch 'remotes/origin/develop' into crankcaseH… 

    …eater
    @mjwitte
    mjwitte committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    95e85af View commit details
    Browse the repository at this point in the history

  2. Minor rules edit

    @mjwitte
    mjwitte committed Aug 4, 2023
    4 Configuration menu
    Copy the full SHA
    cfeba11 View commit details
    Browse the repository at this point in the history

  3. fix global replace err, change 11 back to 10

    @yujiex
    yujiex committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    2ca09b0 View commit details
    Browse the repository at this point in the history

  4. fix non-matching cAlphaFields and AlphArray

    @yujiex
    yujiex committed Aug 4, 2023
    5 Configuration menu
    Copy the full SHA
    6b62dc4 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Merge remote-tracking branch 'origin/develop' into crankcaseHeater

    @yujiex
    yujiex committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    cf72d6e View commit details
    Browse the repository at this point in the history

  2. min-field correction

    @yujiex
    yujiex committed Aug 15, 2023
    5 Configuration menu
    Copy the full SHA
    123b82e View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. fix unit test after merging

    @yujiex
    yujiex committed Aug 16, 2023
    5 Configuration menu
    Copy the full SHA
    75966f3 View commit details
    Browse the repository at this point in the history

  2. fix transition after merge conflict

    @yujiex
    yujiex committed Aug 16, 2023
    5 Configuration menu
    Copy the full SHA
    c0ee5fd View commit details
    Browse the repository at this point in the history

  3. Fix test idf after merge

    @yujiex
    yujiex committed Aug 16, 2023
    5 Configuration menu
    Copy the full SHA
    dd5ccff View commit details
    Browse the repository at this point in the history

  4. crankcaseHeaterCapacityCurveIndex use int, not Real

    @yujiex
    yujiex committed Aug 16, 2023
    5 Configuration menu
    Copy the full SHA
    19a0a8e View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/develop' into crankcaseHeater

    @Myoldmopar
    Myoldmopar committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    d168ed6 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Blending transition rules together, cleaning up fortran, fixing bad v… 

    …ersions in some example files
    @Myoldmopar
    Myoldmopar committed Aug 17, 2023
    5 Configuration menu
    Copy the full SHA
    aac8da8 View commit details
    Browse the repository at this point in the history