Skip to content

Commit

Permalink
idd change, input reading and testing of Coil:WaterHeating:AWHP
Browse files Browse the repository at this point in the history
  • Loading branch information
yujiex committed Apr 26, 2023
1 parent bbfdc1e commit 636e83c
Show file tree
Hide file tree
Showing 4 changed files with 257 additions and 7 deletions.
18 changes: 15 additions & 3 deletions idd/Energy+.idd.in
Original file line number Diff line number Diff line change
Expand Up @@ -58358,7 +58358,7 @@ Coil:WaterHeating:AirToWaterHeatPump:Pumped,
\note ff = fraction of the rated condenser water flow rate.
\note Use curve coefficients of 1,0,0 or leave this field blank when neglecting performance impacts
\note due to variations in water flow rate fraction.
A16; \field Part Load Fraction Correlation Curve Name
A16, \field Part Load Fraction Correlation Curve Name
\type object-list
\object-list UnivariateFunctions
\note Part Load Fraction Correlation (function of part load ratio) should be quadratic or cubic.
Expand All @@ -58367,6 +58367,10 @@ Coil:WaterHeating:AirToWaterHeatPump:Pumped,
\note PLR = part load ratio (heating delivered/steady state heating capacity).
\note Use curve coefficients of 1,0,0 or leave this field blank when neglecting performance impacts
\note due to variations in part load ratio.
A17; \field Outdoor Temperature Dependent Crankcase Heater Capacity Curve Name
\note A Curve:* or Table:Lookup object encoding the relationship between
\note the crankcase heater capacity and the outdoor air temperature. When this field is
\note missing or empty, constant crankcase heater capacity will be assumed.

Coil:WaterHeating:AirToWaterHeatPump:Wrapped,
\memo Heat pump water heater (HPWH) heating coil, air-to-water direct-expansion (DX)
Expand Down Expand Up @@ -58514,7 +58518,7 @@ Coil:WaterHeating:AirToWaterHeatPump:Wrapped,
\note ff = fraction of the rated evaporator air flow rate.
\note Use curve coefficients of 1,0,0 or leave this field blank when neglecting performance impacts
\note due to variations in air flow rate fraction.
A10; \field Part Load Fraction Correlation Curve Name
A10, \field Part Load Fraction Correlation Curve Name
\type object-list
\object-list UnivariateFunctions
\note Part Load Fraction Correlation (function of part load ratio) should be quadratic or cubic.
Expand All @@ -58523,6 +58527,10 @@ Coil:WaterHeating:AirToWaterHeatPump:Wrapped,
\note PLR = part load ratio (heating delivered/steady state heating capacity).
\note Use curve coefficients of 1,0,0 or leave this field blank when neglecting performance impacts
\note due to variations in part load ratio.
A11; \field Outdoor Temperature Dependent Crankcase Heater Capacity Curve Name
\note A Curve:* or Table:Lookup object encoding the relationship between
\note the crankcase heater capacity and the outdoor air temperature. When this field is
\note missing or empty, constant crankcase heater capacity will be assumed.

Coil:WaterHeating:AirToWaterHeatPump:VariableSpeed,
\memo vairlable-speed Heat pump water heater (VSHPWH) heating coil, air-to-water direct-expansion (DX)
Expand Down Expand Up @@ -59481,13 +59489,17 @@ Coil:WaterHeating:AirToWaterHeatPump:VariableSpeed,
\note quadratic curve = a + b*ffa + c*ffa**2
\note cubic curve = a + b*ffa + c*ffa**2 + d*ffa**3
\note ffa = Fraction of the full load Air Flow
A70; \field Speed 10 COP Function of Water Flow Fraction Curve Name
A70, \field Speed 10 COP Function of Water Flow Fraction Curve Name
\type object-list
\object-list UnivariateFunctions
\note Table:Lookup object can also be used
\note quadratic curve = a + b*ffw + c*ffw**2
\note cubic curve = a + b*ffw + c*ffw**2 + d*ffw**3
\note ffw = Fraction of the full load Water Flow
A71; \field Outdoor Temperature Dependent Crankcase Heater Capacity Curve Name
\note A Curve:* or Table:Lookup object encoding the relationship between
\note the crankcase heater capacity and the outdoor air temperature. When this field is
\note missing or empty, constant crankcase heater capacity will be assumed.

Coil:WaterHeating:Desuperheater,
\memo Desuperheater air heating coil. The heating energy provided by this coil is reclaimed
Expand Down
9 changes: 9 additions & 0 deletions src/EnergyPlus/DXCoils.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3428,6 +3428,10 @@ void GetDXCoils(EnergyPlusData &state)
}
}

if (!lAlphaBlanks(17)) {
thisDXCoil.CrankcaseHeaterCapacityCurveIndex = Curve::GetCurveIndex(state, Alphas(17));
}

// assume compressor resides at the inlet to the DX Coil
thisDXCoil.CondenserInletNodeNum(1) = thisDXCoil.AirInNode;

Expand Down Expand Up @@ -3809,6 +3813,11 @@ void GetDXCoils(EnergyPlusData &state)
}
}

// Coil:WaterHeating:AirToWaterHeatPump:Wrapped
if (!lAlphaBlanks(11)) {
thisDXCoil.CrankcaseHeaterCapacityCurveIndex = Curve::GetCurveIndex(state, Alphas(11));
}

// assume compressor resides at the inlet to the DX Coil
thisDXCoil.CondenserInletNodeNum(1) = thisDXCoil.AirInNode;

Expand Down
5 changes: 5 additions & 0 deletions src/EnergyPlus/VariableSpeedCoils.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3034,6 +3034,11 @@ namespace VariableSpeedCoils {
state.dataVariableSpeedCoils->VarSpeedCoil(DXCoilNum).MSRatedTotCap(I);
}

if (!lAlphaBlanks(71)) {
state.dataVariableSpeedCoils->VarSpeedCoil(DXCoilNum).CrankcaseHeaterCapacityCurveIndex =
Curve::GetCurveIndex(state, AlphArray(71));
}

// CurrentModuleObject = "Coil:Waterheating:Airtowaterheatpump:Variablespeed"
SetupOutputVariable(state,
"Cooling Coil Electricity Energy",
Expand Down
Loading

5 comments on commit 636e83c

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crankcaseHeater (yujiex) - Win64-Windows-10-VisualStudio-16: OK (2632 of 2632 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crankcaseHeater (yujiex) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (3444 of 3445 tests passed, 0 test warnings)

Messages:\n

  • 1 test had: EIO diffs.
  • 1 test had: ESO small diffs.
  • 1 test had: MTR small diffs.
  • 1 test had: Table big diffs.

Failures:\n

regression Test Summary

  • Passed: 790
  • Failed: 1

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crankcaseHeater (yujiex) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1860 of 1860 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crankcaseHeater (yujiex) - x86_64-MacOS-10.17-clang-13.0.0: OK (3404 of 3404 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crankcaseHeater (yujiex) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: OK (775 of 776 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 775
  • Failed: 1

Build Badge Test Badge Coverage Badge

Please sign in to comment.