Add heater curve code in Coil:Cooling:DX:CurveFit:Performance

NREL · Jun 1, 2023 · f624b7b · f624b7b · nrel-bot · Jun 1, 2023
1 parent 717a341
commit f624b7b
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 3 deletions.
diff --git a/src/EnergyPlus/Coils/CoilCoolingDXCurveFitPerformance.cc b/src/EnergyPlus/Coils/CoilCoolingDXCurveFitPerformance.cc
@@ -366,6 +366,9 @@ void CoilCoolingDXCurveFitPerformance::simulate(EnergyPlus::EnergyPlusData &stat
     // calculate crankcase heater operation
     if (state.dataEnvrn->OutDryBulbTemp < this->maxOutdoorDrybulbForBasin) {
         this->crankcaseHeaterPower = this->crankcaseHeaterCap;
+        if (this->crankcaseHeaterCapacityCurveIndex > 0) {
+            this->crankcaseHeaterPower = Curve::CurveValue(state, this->crankcaseHeaterCapacityCurveIndex, state.dataEnvrn->OutDryBulbTemp);
+        }
     } else {
         this->crankcaseHeaterPower = 0.0;
     }

diff --git a/tst/EnergyPlus/unit/Coils/CoilCoolingDXCurveFitOperatingMode.unit.cc b/tst/EnergyPlus/unit/Coils/CoilCoolingDXCurveFitOperatingMode.unit.cc
@@ -49,14 +49,15 @@
 #include <gtest/gtest.h>
 
 // EnergyPlus Headers
-#include "../Coils/CoilCoolingDXFixture.hh"
 #include <EnergyPlus/Coils/CoilCoolingDX.hh>
 #include <EnergyPlus/CurveManager.hh>
 #include <EnergyPlus/DataEnvironment.hh>
 #include <EnergyPlus/DataSizing.hh>
 #include <EnergyPlus/OutputReportPredefined.hh>
 #include <EnergyPlus/OutputReportTabular.hh>
 
+#include "../Coils/CoilCoolingDXFixture.hh"
+
 using namespace EnergyPlus;
 
 TEST_F(CoilCoolingDXTest, CoilCoolingDXCurveFitModeInput)
@@ -244,7 +245,7 @@ TEST_F(CoilCoolingDXTest, CoilCoolingDXCurveFitCrankcaseHeaterCurve)
          "heaterCapCurve,          !- Name",
          "10.0,                    !- Coefficient1 Constant",
          "2.,                      !- Coefficient2 x",
-         "10.0,                    !- Minimum Value of x",
+         "-10.0,                    !- Minimum Value of x",
          "70;                      !- Maximum Value of x",
 
          "Coil:Cooling:DX:CurveFit:OperatingMode,",
@@ -265,8 +266,35 @@ TEST_F(CoilCoolingDXTest, CoilCoolingDXCurveFitCrankcaseHeaterCurve)
     idf_objects += this->getSpeedObjectString("Coil Cooling DX Curve Fit Speed 1");
     EXPECT_TRUE(process_idf(idf_objects, false));
     int coilIndex = CoilCoolingDX::factory(*state, "Coil Cooling DX 1");
-    auto const &thisCoil(state->dataCoilCooingDX->coilCoolingDXs[coilIndex]);
+    auto &thisCoil(state->dataCoilCooingDX->coilCoolingDXs[coilIndex]);
     EXPECT_EQ("COIL COOLING DX 1", thisCoil.name);
     EXPECT_EQ("COIL COOLING DX CURVE FIT PERFORMANCE 1", thisCoil.performance.name);
     EXPECT_EQ("HEATERCAPCURVE", Curve::GetCurveName(*state, thisCoil.performance.crankcaseHeaterCapacityCurveIndex));
+
+    int useAlternateMode = DataHVACGlobals::coilNormalMode;
+    Real64 PLR = 1.0;
+    int speedNum = 1;
+    Real64 speedRatio = 1.0;
+    int fanOpMode = 1;
+    bool singleMode = false;
+    state->dataEnvrn->OutDryBulbTemp = 1.0;
+    // thisCoil.simulate(*state, useAlternateMode, PLR, speedNum, speedRatio, fanOpMode, singleMode);
+    auto &evapInletNode = state->dataLoopNodes->Node(thisCoil.evapInletNodeIndex);
+    auto &evapOutletNode = state->dataLoopNodes->Node(thisCoil.evapOutletNodeIndex);
+    auto &condInletNode = state->dataLoopNodes->Node(thisCoil.condInletNodeIndex);
+    auto &condOutletNode = state->dataLoopNodes->Node(thisCoil.condOutletNodeIndex);
+    Real64 LoadSHR = 0.0;
+    thisCoil.performance.simulate(*state,
+                                  evapInletNode,
+                                  evapOutletNode,
+                                  useAlternateMode,
+                                  PLR,
+                                  speedNum,
+                                  speedRatio,
+                                  fanOpMode,
+                                  condInletNode,
+                                  condOutletNode,
+                                  singleMode,
+                                  LoadSHR);
+    EXPECT_EQ(thisCoil.performance.crankcaseHeaterPower, 12.0);
 }