Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(table-mode): add missing properties for v8.6 and 8.7 #1643

Merged
merged 51 commits into from
Apr 23, 2024
Merged

feat(table-mode): add missing properties for v8.6 and 8.7 #1643

merged 51 commits into from
Apr 23, 2024

Conversation

skamril
Copy link
Member

@skamril skamril commented Jul 7, 2023 •
edited
Loading

No description provided.

@skamril skamril force-pushed the feature/1520_table_mode_pollutants branch from fd1a49e to f6d5da1 Compare July 13, 2023 08:41
@skamril skamril linked an issue Jul 13, 2023 that may be closed by this pull request
[ANT-702] Add missing pollutants in the table mode #1520
Closed
laurent-laporte-pro
laurent-laporte-pro suggested changes Jul 16, 2023
View reviewed changes
antarest/study/business/utils.py Outdated Show resolved Hide resolved
antarest/study/business/table_mode_management.py Outdated Show resolved Hide resolved
@laurent-laporte-pro

This comment was marked as resolved.

Sign in to view
@laurent-laporte-pro

This comment was marked as resolved.

Sign in to view
@skamril skamril force-pushed the feature/1520_table_mode_pollutants branch from be940bb to 540bdd2 Compare July 31, 2023 08:21
@skamril skamril force-pushed the feature/1520_table_mode_pollutants branch from 540bdd2 to eff82d8 Compare July 31, 2023 11:51
@skamril skamril force-pushed the feature/1520_table_mode_pollutants branch from eff82d8 to 95473ed Compare November 29, 2023 09:13
@skamril skamril force-pushed the feature/1520_table_mode_pollutants branch from 95473ed to fe8dbee Compare December 5, 2023 14:24
@AntaresSimulatorTeam AntaresSimulatorTeam deleted a comment from commit-lint bot Dec 5, 2023
This was referenced Dec 11, 2023
Closed
Closed
@watermelon-copilot-for-code-review watermelon-copilot-for-code-review bot mentioned this pull request Dec 18, 2023
Draft
6 tasks
@watermelon-copilot-for-code-review watermelon-copilot-for-code-review bot mentioned this pull request Jan 2, 2024
Merged
@skamril skamril marked this pull request as draft January 25, 2024 10:20
@laurent-laporte-pro laurent-laporte-pro force-pushed the feature/1520_table_mode_pollutants branch from fe8dbee to fdc82a1 Compare March 3, 2024 18:06
laurent-laporte-pro and others added 13 commits April 23, 2024 12:32
@laurent-laporte-pro @skamril
test(tablemode): correct Table Mode unit test
8ad85b5
@laurent-laporte-pro @skamril
feat(tablemode): avoid sending columns with empty values
de1c0d5
@laurent-laporte-pro @skamril
feat(tablemode): improve validation of filtering fields
1fad0f1
@laurent-laporte-pro @skamril
feat(tablemode): improve DataFrame to JSON conversion
9f22cde
@laurent-laporte-pro @skamril
feat(tablemode): validate filter_synthesis, filter_year_by_year f…
e9e0a89 
…ields for BC
@laurent-laporte-pro @skamril
feat(tablemode): remove colorRgb column from Table template
72aa56c
@laurent-laporte-pro @skamril
test(tablemode): correct unit tests ("colorRgb" is removed)
d642c13
@laurent-laporte-pro @skamril
feat(tablemode): change in TableModeType to handle aliases of old t…
bc1285c 
…able types
@laurent-laporte-pro @skamril
refactor(config): refactor validation of colors in Area and Link models
b542ef8
@laurent-laporte-pro @skamril
fix(area): correct endpoint to update Area UI
7cb7166
@laurent-laporte-pro @skamril
refactor(api-ui): update studydata
e167300
@skamril
fix(storage): issue to run server
8c42941
@skamril
feat(tablemode-ui): only display columns of study version
e2e44c6
@skamril skamril force-pushed the feature/1520_table_mode_pollutants branch from b6fbdc3 to dc2b616 Compare April 23, 2024 10:33
@skamril skamril force-pushed the feature/1520_table_mode_pollutants branch from dc2b616 to f3863c2 Compare April 23, 2024 10:57
hdinia
hdinia previously approved these changes Apr 23, 2024
View reviewed changes
@laurent-laporte-pro laurent-laporte-pro dismissed stale reviews from hdinia and themself via 893cdd4 April 23, 2024 15:23
@laurent-laporte-pro laurent-laporte-pro merged commit 074dea8 into dev Apr 23, 2024
6 of 7 checks passed
@laurent-laporte-pro laurent-laporte-pro deleted the feature/1520_table_mode_pollutants branch April 23, 2024 16:12
@laurent-laporte-pro laurent-laporte-pro added this to the v2.17 milestone Apr 23, 2024
@laurent-laporte-pro laurent-laporte-pro mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurent-laporte-pro laurent-laporte-pro laurent-laporte-pro approved these changes

@hdinia hdinia hdinia left review comments

Assignees

@skamril skamril

@laurent-laporte-pro laurent-laporte-pro

Labels
size/XXL
Projects
None yet
Milestone
v2.17
Development

Successfully merging this pull request may close these issues.

[ANT-702] Add missing pollutants in the table mode
3 participants
@skamril @laurent-laporte-pro @hdinia