Remove uses of Yuni::Mutex, use std::mutex instead

[NicolasSalmieriScalian]

No description provided.

[watermelon-copilot-for-code-review]

Watermelon AI Summary

AI Summary deactivated by NicolasSalmieriScalian

No results found in GitHub PRs :(

No results found in Jira Tickets :(

No results found in Confluence Docs :(

No results found in Slack Threads :(

No results found in Notion Pages :(

No results found in Linear Tickets :(

No results found in Asana Tasks :(

Antares_Simulator is an open repo and Watermelon will serve it for free.
🍉🫶
Have you starred Watermelon?

[flomnes]

LGTM. We usually don't specify template arguments when they're obvious, from C++17 they're deduced, see here. We have been using C++17 for over a year, and will soon be using C++20.

std::mutex mutex;
std::lock_guard<std::mutex> lock(mutex); // C++03/C++11
std::lock_guard lock(mutex); // C++17

[NicolasSalmieriScalian]

LGTM. We usually don't specify template arguments when they're obvious, from C++17 they're deduced, see here. We have been using C++17 for over a year, and will soon be using C++20.

std::mutex mutex;
std::lock_guard<std::mutex> lock(mutex); // C++03/C++11
std::lock_guard lock(mutex); // C++17

Should I remove all obvious template arguments of std::lock_guard in the codebase, or just those I added?

[flomnes]

Should I remove all obvious template arguments of std::lock_guard in the codebase, or just those I added?

Can you please remove them all ?

[a-zakir]

LGTM. We usually don't specify template arguments when they're obvious, from C++17 they're deduced, see here. We have been using C++17 for over a year, and will soon be using C++20.

std::mutex mutex;
std::lock_guard<std::mutex> lock(mutex); // C++03/C++11
std::lock_guard lock(mutex); // C++17

Should I remove all obvious template arguments of std::lock_guard in the codebase, or just those I added?

LGTM. We usually don't specify template arguments when they're obvious, from C++17 they're deduced, see here. We have been using C++17 for over a year, and will soon be using C++20.

std::mutex mutex;
std::lock_guard<std::mutex> lock(mutex); // C++03/C++11
std::lock_guard lock(mutex); // C++17

Should I remove all obvious template arguments of std::lock_guard in the codebase, or just those I added?

you named this Pr "Remove uses of Yuni::Mutex, use std::mutex instead " should i....

[flomnes]

Hi @NicolasSalmieriScalian, can you please resolve conflicts ? Our license has switched to MPL 2.0, allowing us to merge PRs from you

[flomnes]

See #1964