Feature/low level logs #723
Conversation
| const std::string MATHLOGGERCONTEXT = "Benders"; | ||
|
|
||
| inline std::string Indent(int size) { return std::string(size, ' '); } | ||
| const std::string ITE = Indent(10) + "ITE"; |
There was a problem hiding this comment.
As we have clean indents we may use ITERATION instead of ITE and adjust indentation
| public: | ||
| explicit LogDestination(std::ostream* stream) : stream_(stream) {} | ||
|
|
||
| // for std::endl |
There was a problem hiding this comment.
Remove commented code if useless
| @@ -153,6 +155,8 @@ void BendersMpi::master_build_cuts( | |||
| for (const auto &subproblem_data_map : gathered_subproblem_map) { | |||
| for (auto &&[_, subproblem_data] : subproblem_data_map) { | |||
| SetSubproblemCost(GetSubproblemCost() + subproblem_data.subproblem_cost); | |||
| // compute delta_cut >= options.CUT_MASTER_TOL; | |||
There was a problem hiding this comment.
This comment does not seem related to what happens here
There was a problem hiding this comment.
yes it's a reminder for a specific data....
| void MathLogger::write_header() { | ||
| setHeadersList(); | ||
| for (const auto& header : Headers()) { | ||
| TheLogDestination() << header; |
There was a problem hiding this comment.
LogDestination() instead of TheLogDestination() seems more natural
There was a problem hiding this comment.
i've a struct named LogDestination, i suggest LogsDestination
| void MathLoggerBase::Print(const CurrentIterationData& data) { | ||
| TheLogDestination() << Indent(10) << data.it; | ||
| if (data.lb == -1e20) | ||
| TheLogDestination() << Indent(20) << "-INF"; |
There was a problem hiding this comment.
I prefer that we really print 1e+20 and 1e-20 in the math logs as these are the actual values of the data. the purpose of the math logs is to monitor exactly what happens in the data and not to have an interpretation of it as infinity
|
|
||
| void MathLoggerBendersByBatch::Print(const CurrentIterationData& data) { | ||
| TheLogDestination() << Indent(10) << data.it; | ||
| if (data.lb == -1e20) |
| void MathLoggerBendersByBatch::setHeadersList() { | ||
| MathLogger::setHeadersList({ITE, LB, MINSIMPLEX, MAXSIMPLEX, TIMEMASTER, | ||
| SUB_PROBLEMS_TIME_CPU, SUB_PROBLEMS_TIME_WALL, | ||
| TIME_NOT_DOING_MASTER_OR_SUB_PROBLEMS_WALL}); |
There was a problem hiding this comment.
Can we also add this log to the base case ?
| TheLogDestination() << Indent(15) << std::setprecision(2) | ||
| << data.subproblems_walltime; | ||
|
|
||
| TheLogDestination() << std::endl; |
Watermelon AI SummaryAI Summary deactivated by a-zakir No results found in GitHub PRs :( No results found in Jira Tickets :( No results found in Confluence Docs :( No results found in Slack Threads :( No results found in Notion Pages :( No results found in Linear Tickets :( No results found in Asana Tasks :( antares-xpansion is an open repo and Watermelon will serve it for free. |
![watermelon-copilot-for-code-review[bot]](https://avatars.githubusercontent.com/in/327523?s=60&v=4){kind=small}
| @@ -537,7 +537,7 @@ def update_last_study_with_sensitivity_results(self): | |||
|
|
|||
There was a problem hiding this comment.
This PR contains console logs. Please review or remove them.
| @@ -17,6 +17,7 @@ int RunBenders(char** argv, const std::filesystem::path& options_file, | |||
| const BENDERSMETHOD& method) { | |||
There was a problem hiding this comment.
This PR contains console logs. Please review or remove them.
| setHeadersList(); | ||
| for (const auto& header : Headers()) { | ||
| LogsDestination() << header; | ||
| } |
There was a problem hiding this comment.
This PR contains console logs. Please review or remove them.
watermelon-copilot-for-code-review
bot
added
🚨 Don't Merge
and removed
👀 Take a deeper dive
labels
| @@ -537,7 +537,7 @@ def update_last_study_with_sensitivity_results(self): | |||
|
|
|||
| def is_antares_study_output(self, study: Path): | |||
| _, ext = os.path.splitext(study) | |||
| return ext == ".zip" or os.path.isdir(study) and '-Xpansion' not in study.name | |||
| return ext == ".zip" or (os.path.isdir(study) and '-Xpansion' in study.name) | |||
|
|
|||
There was a problem hiding this comment.
This PR contains console logs. Please review or remove them.
| @@ -56,7 +56,7 @@ BENDERS_OPTIONS_MACRO(SOLVER_NAME, std::string, "COIN", asString()) | |||
| // json file in output/expansion/ | |||
There was a problem hiding this comment.
This PR contains console logs. Please review or remove them.
see review and history in #723 --------- Co-authored-by: Thomas Bittar <[email protected]>
No description provided.