[ANT-992] Add ramping for thermal clusters #1817

bencamus · 2023-12-11T17:12:01Z

This code implement the thermal ramping model in Antares.
The remaining works are:

validate the equation of the constraints (the specification might be improved).
validate the constraint implementation for the first hour of each week (currently it is cyclical as the evolution of the production for the first hour is constrained the production of the last hour).
initialise by default the upward and downward power ramp to +inf (or any large value compliant with the optimization solver).
define and integrate unit tests for the thermal ramping.
validate the implementation with a sound use case.
validate the integration with the Antares Web GUI.

watermelon-copilot-for-code-review · 2023-12-11T17:12:08Z

Watermelon AI Summary

AI Summary deactivated by bencamus

GitHub PRs

#1817 - Feature/ramping model scalian - By bencamus 1 weeks ago
#1017 - [DEV] Refactoring parallelization computation and remove duplication from solver - By kathvargasr 1 years ago
#1798 - Delete "rename" process and useless calls around - By JasonMarechal25 3 weeks ago

Antares_Simulator is an open repo and Watermelon will serve it for free.
🍉🫶

a-zakir · 2023-12-12T10:36:38Z

src/libs/antares/study/parts/thermal/cluster.cpp

+    {
+        logs.error() << "Thermal cluster: " << parentArea->name << '/' << pName
+                     << ": The maximum upward power ramping rate must greater than zero.";
+        maxUpwardPowerRampingRate = 1.;


i would be helpful to print the fallback value;
also it seems that the return value is never used

Now, with commit 8133150, the ramping is disabled in this case, and this information is printed.

a-zakir · 2023-12-12T10:38:37Z

src/solver/optimisation/constraints/ConstraintBuilder.cpp

@@ -58,6 +58,25 @@ ConstraintBuilder& ConstraintBuilder::DispatchableProduction(unsigned int index,
                                                             int delta)
 {
    AddVariable(GetVariableManager(offset, delta).DispatchableProduction(index), coeff);
+    // logs.info() << "dispatchable production idx " << GetVariableManager(offset, delta).DispatchableProduction(index);
+    return *this;


remove debug comments

fixed in commit 624f2ce

src/solver/optimisation/constraints/PowerOutputVariation.cpp

src/solver/optimisation/constraints/RampingDecreaseRate.cpp

src/solver/optimisation/constraints/RampingIncreaseRate.cpp

src/libs/antares/study/parts/thermal/cluster.cpp

flomnes · 2023-12-12T10:23:56Z

src/libs/antares/study/parts/thermal/cluster_list.cpp

+                s->add("max-upward-power-ramping-rate", Math::Round(c.maxUpwardPowerRampingRate, 3));
+            if (not Math::Zero(c.maxDownwardPowerRampingRate))


Math is part of Yuni, which is deprecated. Please use STL functions instead.

fixed by commit 915e0c7

flomnes · 2023-12-12T10:32:22Z

src/solver/optimisation/constraints/PowerOutputVariation.cpp

+        int add = (pdt == 0) ? 4 : 5;
+        problemeHebdo->NbTermesContraintesPourLesRampes += add;
+        problemeHebdo->ProblemeAResoudre->NombreDeContraintes++;
+    }


To be checked carefully

with commit 624f2ce, the ramping constraints become cyclical (the evolution of the production for the first hour is constrained the production of the last hour). Then, we don't need to use a constraint for the first time step that is different from the other time steps anymore. This code is now removed.

flomnes · 2023-12-12T10:34:05Z

src/solver/optimisation/constraints/RampingDecreaseRate.cpp

+        if (pdt > 0)
+        {
+            builder.updateHourWithinWeek(pdt)
+              .DispatchableProduction(cluster, 1.0)
+              .DispatchableProduction(cluster, -1.0, -1, problemeHebdo->NombreDePasDeTempsPourUneOptimisation)
+              .NumberOfDispatchableUnits(cluster, maxDownwardPowerRampingRate)
+              .NumberStoppingDispatchableUnits(cluster, pmaxDUnGroupeDuPalierThermique)
+              .NumberBreakingDownDispatchableUnits(cluster, pmaxDUnGroupeDuPalierThermique)
+              .greaterThan();
+        }


You shouldn't need this if..else since DispatchableProduction has arguments to take this into account.

Indeed, commit 624f2ce fixed this.

flomnes · 2023-12-12T10:40:36Z

src/solver/optimisation/constraints/RampingIncreaseRate.cpp

@@ -0,0 +1,47 @@
+#include "RampingIncreaseRate.h"
+
+void RampingIncreaseRate::add(int pays, int cluster, int clusterIndex, int pdt, bool Simulation)


You may define a class both for RampingIncreaseRate and RampingDecreaseRate. With a pure virtual method for behaviors that differ, e.g

-.NumberOfDispatchableUnits(cluster, -maxUpwardPowerRampingRate) -.NumberStartingDispatchableUnits(cluster, -pminDUnGroupeDuPalierThermique) +.NumberStoppingDispatchableUnits(cluster, pmaxDUnGroupeDuPalierThermique) +.NumberBreakingDownDispatchableUnits(cluster, pmaxDUnGroupeDuPalierThermique)

See https://refactoring.guru/design-patterns/template-method

Pending until the constraint equations are validated

src/solver/optimisation/opt_gestion_des_bornes_rampes_thermiques.cpp

src/solver/optimisation/opt_construction_variables_rampes_thermiques.h

src/solver/optimisation/opt_fonctions.h

flomnes

It seems that 0 is not a suitable value for maxDownwardPowerRampingRate, consider choosing a different default value.

flomnes

Suggestion : add ON/OFF (bool, default = OFF) for ramping in every cluster

a-zakir · 2023-12-13T10:48:08Z

Please add test(s) for the newly constraints at least in "named-mps" tests, let me know if i can be of any help

…ion for the first hour is constrained the production of the last hour + remove commented ramping debug logs

…rs in the header file

flomnes · 2023-12-19T12:13:21Z

src/libs/antares/study/parts/thermal/cluster.cpp

@@ -137,7 +137,8 @@ Data::ThermalCluster::ThermalCluster(Area* parent) :
    forcedLaw(thermalLawUniform),
    plannedLaw(thermalLawUniform),
    PthetaInf(HOURS_PER_YEAR, 0),
-    costsTimeSeries(1, CostsTimeSeries())
+    costsTimeSeries(1, CostsTimeSeries()),
+    ramping()


This constructor is called by default, there is no need to call it explicitly here

removed in commit 77daa36

flomnes · 2023-12-19T12:15:15Z

src/libs/antares/study/parts/thermal/cluster.h

+        bool checkValidity(Area* area, Data::ClusterName clusterName);
+        friend std::ostream& operator<<(std::ostream&, const Ramping& ramping);
+    };
+    Ramping ramping;


Suggested change

Ramping ramping;

std::optional<Ramping> ramping;

By default, the ramping constraints are not enabled for a given cluster. They are enabled only if an object exists within this std::optional.

Possible justification : there is no good default value for maxUpwardPowerRampingRate and maxDownwardPowerRampingRate, ie we can't keep the existing behavior by default, which is very important.

This induces a small difficulty in the variable/constraint counting process, in the sense that we must only take into account cluster for which ramping is enabled.

Commit 8133150 implements now is feature

flomnes · 2024-02-19T12:19:40Z

src/libs/antares/study/parts/thermal/cluster_list.cpp

+        bool rampingEnabled = false;
+        bool attributeOK = rampingEnabledProperty->value.to<bool>(rampingEnabled);
+        if (rampingEnabled && attributeOK)
+            cluster.ramping = ThermalCluster::Ramping();


Suggested change

cluster.ramping = ThermalCluster::Ramping();

cluster.ramping.emplace();

Otherwise the temporary object is constructed and destructed immediately. In-place construction saves one Construction/Destruction, see https://en.cppreference.com/w/cpp/utility/optional/emplace

flomnes · 2024-02-19T12:22:59Z

src/solver/optimisation/opt_decompte_variables_et_contraintes.cpp

-        ProblemeAResoudre->NombreDeVariables
-          += problemeHebdo->PaliersThermiquesDuPays[pays].NombreDePaliersThermiques;
-
+        ProblemeAResoudre->NombreDeVariables += problemeHebdo->PaliersThermiquesDuPays[pays].NombreDePaliersThermiques;


Formatting, see .clang-format

flomnes · 2024-02-19T14:52:47Z

src/solver/simulation/sim_calcul_economique.cpp

+                pbPalier.upwardRampingCost[nRampingCluster]
+                  = cluster.ramping.value().powerIncreaseCost;
+                pbPalier.downwardRampingCost[nRampingCluster]
+                  = cluster.ramping.value().powerDecreaseCost;
+                pbPalier.maxDownwardPowerRampingRate[nRampingCluster]
+                  = cluster.ramping.value().maxDownwardPowerRampingRate;
+                pbPalier.maxUpwardPowerRampingRate[nRampingCluster]
+                  = cluster.ramping.value().maxUpwardPowerRampingRate;
+                pbPalier.clusterRampingVariablesIndex[clusterIndex] = nRampingCluster;
+                nRampingCluster++;


Suggested change

pbPalier.upwardRampingCost[nRampingCluster]

= cluster.ramping.value().powerIncreaseCost;

pbPalier.downwardRampingCost[nRampingCluster]

= cluster.ramping.value().powerDecreaseCost;

pbPalier.maxDownwardPowerRampingRate[nRampingCluster]

= cluster.ramping.value().maxDownwardPowerRampingRate;

pbPalier.maxUpwardPowerRampingRate[nRampingCluster]

= cluster.ramping.value().maxUpwardPowerRampingRate;

pbPalier.clusterRampingVariablesIndex[clusterIndex] = nRampingCluster;

nRampingCluster++;

const auto& ramping = cluster.ramping.value();

pbPalier.upwardRampingCost[nRampingCluster]

= ramping.powerIncreaseCost;

pbPalier.downwardRampingCost[nRampingCluster]

= ramping.powerDecreaseCost;

pbPalier.maxDownwardPowerRampingRate[nRampingCluster]

= ramping.maxDownwardPowerRampingRate;

pbPalier.maxUpwardPowerRampingRate[nRampingCluster]

= ramping.maxUpwardPowerRampingRate;

pbPalier.clusterRampingVariablesIndex[clusterIndex] = nRampingCluster;

nRampingCluster++;

flomnes · 2024-02-19T14:55:16Z

src/solver/simulation/sim_alloc_probleme_hebdo.cpp

+        variablesMapping.powerRampingIncreaseIndex
+          .assign(study.runtime->thermalPlantTotalCount, 0);
+        variablesMapping.powerRampingDecreaseIndex
          .assign(study.runtime->thermalPlantTotalCount, 0);


By default, the variable doesn't exist

Suggested change

variablesMapping.powerRampingIncreaseIndex

.assign(study.runtime->thermalPlantTotalCount, 0);

variablesMapping.powerRampingDecreaseIndex

.assign(study.runtime->thermalPlantTotalCount, 0);

variablesMapping.powerRampingIncreaseIndex

.assign(study.runtime->thermalPlantTotalCount, -1);

variablesMapping.powerRampingDecreaseIndex

.assign(study.runtime->thermalPlantTotalCount, -1);

src/solver/optimisation/constraints/RampingIncreaseRate.cpp

…zing the NODU variables during the second optimization step for the cluster with ramping

… problemhebdo constrainst vectors length

… ramping model to fix issue with ramping behavior + update of the output ramping cost to be aligned with the constraints

… PLANT

…nits as it is already included in the starting thermal units term

…nto feature/ramping_model_scalian

bencamus added 2 commits December 5, 2023 17:17

core implementation of the ramping model

a64625a

add export/import features for the thermal ramping attributes

b9c4f2b

pull-request-size bot added the size/XL label Dec 11, 2023

watermelon-copilot-for-code-review bot added the 🚨 Don't Merge label Dec 11, 2023