-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Config discovery #37
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
===========================================
- Coverage 40.68% 30.17% -10.51%
===========================================
Files 21 26 +5
Lines 1728 2525 +797
Branches 1728 2525 +797
===========================================
+ Hits 703 762 +59
- Misses 1012 1747 +735
- Partials 13 16 +3
☔ View full report in Codecov by Sentry. |
Signed-off-by: iGxnon <[email protected]>
1 task
1 task
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
This PR add a configuration discovery on operator, sidecar with an incomplete config could fetch the latest config from operator. This gives the sidecars the ability to discover each other and reconcile on a right majority.
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)