Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidecar metrics #38

Closed
wants to merge 19 commits into from
Closed

Sidecar metrics #38

wants to merge 19 commits into from

Conversation

iGxnon
Copy link
Collaborator

@iGxnon iGxnon commented Nov 1, 2023

Base on #37

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

iGxnon added 19 commits October 25, 2023 14:18
Signed-off-by: iGxnon <[email protected]>
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 1220 lines in your changes are missing coverage. Please review.

Comparison is base (0627722) 40.68% compared to head (d7339d0) 29.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #38       +/-   ##
===========================================
- Coverage   40.68%   29.00%   -11.68%     
===========================================
  Files          21       26        +5     
  Lines        1728     2627      +899     
  Branches     1728     2627      +899     
===========================================
+ Hits          703      762       +59     
- Misses       1012     1849      +837     
- Partials       13       16        +3     
Files Coverage Δ
operator-k8s/src/lib.rs 100.00% <ø> (ø)
sidecar/src/backup/mod.rs 80.00% <ø> (ø)
sidecar/src/backup/pv.rs 0.00% <ø> (ø)
sidecar/src/lib.rs 100.00% <ø> (ø)
operator-k8s/src/controller/cluster/v1alpha1.rs 0.00% <0.00%> (ø)
operator-k8s/src/config.rs 0.00% <0.00%> (ø)
crd-api/src/version.rs 74.35% <0.00%> (ø)
operator-k8s/src/manager/cluster.rs 79.58% <0.00%> (-0.50%) ⬇️
crd-api/src/v1alpha1/cluster.rs 92.63% <71.42%> (ø)
sidecar/src/utils.rs 52.27% <0.00%> (-9.89%) ⬇️
... and 14 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iGxnon iGxnon closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant