Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: public access for CRD struct #32

Closed
1 task done
liangyuanpeng opened this issue Sep 18, 2023 · 7 comments
Closed
1 task done

[Feature]: public access for CRD struct #32

liangyuanpeng opened this issue Sep 18, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@liangyuanpeng
Copy link
Contributor

liangyuanpeng commented Sep 18, 2023

Description about the feature

Wee need to allow users to operate crd resources outside xline-operator (for example, create xline cluster), which means that the struct corresponding to operator crd should be publicly accessible, currently within the crate scope.

pub(crate) struct ClusterSpec {
/// Size of the xline cluster, less than 3 is not allowed
#[cfg_attr(test, garde(range(min = 3)))]

This is a good first issue for me, i want to work for it and assign me please,Thanks. Remind me if i missed something.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@liangyuanpeng liangyuanpeng added the enhancement New feature or request label Sep 18, 2023
@liangyuanpeng liangyuanpeng changed the title [Feature]: public access for Cluster [Feature]: public access for CRD struc Sep 18, 2023
@liangyuanpeng liangyuanpeng changed the title [Feature]: public access for CRD struc [Feature]: public access for CRD struct Sep 21, 2023
@iGxnon
Copy link
Collaborator

iGxnon commented Sep 25, 2023

Should xline-operator be used as a binary, so there is no need to provide a public CRD definition as a library?

@liangyuanpeng
Copy link
Contributor Author

Absolutely, xline-operator run as a binary, At the same time, the CRD definition should also be provided as a libiary so that others can use it.

Let user can apply CR with rust code and not kubectl for integration into their platform.

@iGxnon
Copy link
Collaborator

iGxnon commented Sep 26, 2023

Absolutely, xline-operator run as a binary, At the same time, the CRD definition should also be provided as a libiary so that others can use it.

Let user can apply CR with rust code and not kubectl for integration into their platform.

That makes sense, I suggest move these CRDs into a separated crate.

@liangyuanpeng
Copy link
Contributor Author

I suggest move these CRDs into a separated crate.

@iGxnon ,How about xline-operator-api, I thought this might cause some confusion given that the operator-api crate already exists.

@iGxnon
Copy link
Collaborator

iGxnon commented Oct 25, 2023

I suggest move these CRDs into a separated crate.

@iGxnon ,How about xline-operator-api, I thought this might cause some confusion given that the operator-api crate already exists.

operator-api is used to reduce the coupling between operator and sidecar. A simple name crd-api might be sufficient

@iGxnon
Copy link
Collaborator

iGxnon commented Oct 27, 2023

I'll handle this in #37

@iGxnon iGxnon linked a pull request Oct 27, 2023 that will close this issue
@liangyuanpeng
Copy link
Contributor Author

This is not need any more due to the xline-operator is rewriting with golang.

closing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants