Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definedBy property for authenticator databases. #5991

Conversation

Thisara-Welmilla
Copy link
Contributor

@Thisara-Welmilla Thisara-Welmilla commented Oct 4, 2024

Task Issue:

Related PRs:

With this following properties will be introduce to the authenticator configs and Application Authenticators.

  • DefinedBy - to indicate whether the authenticator is system-defined or user-defined.
  1. SYSTEM: Sytem defined authenticators, all the existing authenticators are this type.
  2. USER: User defined authenticators, all the custom authenticators of authentication extension come under this type.

With this PR following changes are added.

  1. Update the database schemas and database queries to accommodate storing this property in the databases.
  2. Improve DAO layer as required.

@Thisara-Welmilla Thisara-Welmilla marked this pull request as ready for review October 4, 2024 08:13
@Thisara-Welmilla Thisara-Welmilla changed the base branch from master to Add-authenticator-properties October 4, 2024 08:23
@Thisara-Welmilla Thisara-Welmilla changed the base branch from Add-authenticator-properties to master October 4, 2024 08:23
@Thisara-Welmilla Thisara-Welmilla changed the base branch from master to add-definedBy-Type October 4, 2024 08:24
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-definedBy-type-prop-db branch 5 times, most recently from 56fd140 to 71ff6ae Compare October 8, 2024 10:49
@Thisara-Welmilla Thisara-Welmilla changed the base branch from add-definedBy-Type to master October 9, 2024 08:35
@Thisara-Welmilla Thisara-Welmilla force-pushed the add-definedBy-type-prop-db branch 3 times, most recently from 78469b8 to d76919c Compare October 10, 2024 08:32
@Thisara-Welmilla Thisara-Welmilla changed the base branch from master to add-definedBy-Type October 10, 2024 14:25
@Thisara-Welmilla Thisara-Welmilla merged commit 5f1b008 into wso2:add-definedBy-Type Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants