Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definedBy property for authenticators. #5990

Conversation

Thisara-Welmilla
Copy link
Contributor

@Thisara-Welmilla Thisara-Welmilla commented Oct 4, 2024

Task Issue:

Related PRs:

With this following properties will be introduce to the authenticator configs and Application Authenticators.

  • DefinedBy - to indicate whether the authenticator is system-defined or user-defined.
  1. SYSTEM: Sytem defined authenticators, all the existing authenticators are this type.
  2. USER: User defined authenticators, all the custom authenticators of authentication extension come under this type.

With this PR following changes are added.

  1. Add new property for authenticator config classes to hold the authenticator definedBy type.
  2. Improve service layer with this property.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 39.88%. Comparing base (64eea15) to head (eb2ca3b).
Report is 10 commits behind head on add-definedBy-Type.

Files with missing lines Patch % Lines
...ion/common/model/FederatedAuthenticatorConfig.java 0.00% 7 Missing ⚠️
...ication/common/model/LocalAuthenticatorConfig.java 0.00% 7 Missing ⚠️
.../identity/base/AuthenticatorPropertyConstants.java 0.00% 4 Missing ⚠️
.../framework/internal/FrameworkServiceComponent.java 0.00% 3 Missing ⚠️
...g/wso2/carbon/idp/mgt/IdentityProviderManager.java 0.00% 3 Missing ⚠️
...n/common/model/RequestPathAuthenticatorConfig.java 0.00% 1 Missing ⚠️
...entication/framework/ApplicationAuthenticator.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##             add-definedBy-Type    #5990      +/-   ##
========================================================
+ Coverage                 39.67%   39.88%   +0.21%     
- Complexity                14218    14327     +109     
========================================================
  Files                      1733     1735       +2     
  Lines                    119164   120657    +1493     
  Branches                  19755    20481     +726     
========================================================
+ Hits                      47278    48125     +847     
- Misses                    64666    65194     +528     
- Partials                   7220     7338     +118     
Flag Coverage Δ
unit 23.92% <0.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thisara-Welmilla Thisara-Welmilla changed the base branch from add-definedBy-Type to master October 9, 2024 08:37
@Thisara-Welmilla Thisara-Welmilla changed the base branch from master to add-definedBy-Type October 10, 2024 14:24
@Thisara-Welmilla Thisara-Welmilla merged commit 9ff18dd into wso2:add-definedBy-Type Oct 11, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants