Add new DefinedBy property to authenticator config. #5938
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Thisara-Welmilla
force-pushed
the
add-auth-prop
branch
from
c4243a8
to
388b5fa
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Thisara-Welmilla
force-pushed
the
add-auth-prop
branch
from
388b5fa
to
02d972c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Thisara-Welmilla
force-pushed
the
add-auth-prop
branch
from
02d972c
to
71e75c3
Compare
|
PR builder started |
|
PR builder completed |
Thisara-Welmilla
force-pushed
the
add-auth-prop
branch
2 times, most recently
from
9fc695e
to
99f7c76
Compare
Thisara-Welmilla
force-pushed
the
add-auth-prop
branch
from
99f7c76
to
b40fb77
Compare
|
PR builder started |
|
PR builder completed |
Thisara-Welmilla
force-pushed
the
add-auth-prop
branch
2 times, most recently
from
038f4a3
to
10bba5c
Compare
Thisara-Welmilla
force-pushed
the
add-auth-prop
branch
from
10bba5c
to
6ab1997
Compare
|
@Thisara-Welmilla please refer to the right issue in this PR |
malithie
reviewed
Sep 23, 2024
...c/main/java/org/wso2/carbon/identity/application/common/ApplicationAuthenticatorService.java
Outdated
Show resolved
Hide resolved
Thisara-Welmilla
force-pushed
the
add-auth-prop
branch
from
e01bdfa
to
a8f8170
Compare
|
PR builder started |
|
PR builder completed |
|
PR builder completed |
jenkins-is-staging
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11064117139
This was referenced Sep 30, 2024
Thisara-Welmilla
force-pushed
the
add-auth-prop
branch
3 times, most recently
from
9f41217
to
2e2a5ea
Compare
Thisara-Welmilla
force-pushed
the
add-auth-prop
branch
from
2e2a5ea
to
2a2c971
Compare
malithie
reviewed
Oct 2, 2024
...ain/java/org/wso2/carbon/identity/application/common/model/FederatedAuthenticatorConfig.java
Outdated
Show resolved
Hide resolved
malithie
reviewed
Oct 3, 2024
...ain/java/org/wso2/carbon/identity/application/common/model/FederatedAuthenticatorConfig.java
Outdated
Show resolved
Hide resolved
malithie
reviewed
Oct 3, 2024
....mgt/src/main/java/org/wso2/carbon/identity/application/mgt/dao/impl/ApplicationDAOImpl.java
Outdated
Show resolved
Hide resolved
malithie
reviewed
Oct 3, 2024
....mgt/src/main/java/org/wso2/carbon/identity/application/mgt/dao/impl/ApplicationDAOImpl.java
Show resolved
Hide resolved
malithie
reviewed
Oct 3, 2024
Comment on lines
5037
to
5039
| // TODO: Read from database and set the DefinedBy and authenticationType properties to the authenticator. | ||
| returnData.put(ApplicationConstants.IDP_AUTHENTICATOR_DEFINED_BY_TYPE, | ||
| IdentityConstants.DefinedByType.SYSTEM.toString()); |
malithie
reviewed
Oct 3, 2024
...test/java/org/wso2/carbon/identity/application/mgt/ApplicationManagementServiceImplTest.java
Outdated
Show resolved
Hide resolved
malithie
reviewed
Oct 3, 2024
...test/java/org/wso2/carbon/identity/application/mgt/ApplicationManagementServiceImplTest.java
Outdated
Show resolved
Hide resolved
malithie
reviewed
Oct 3, 2024
.../org/wso2/carbon/identity/application/authentication/framework/ApplicationAuthenticator.java
Outdated
Show resolved
Hide resolved
malithie
reviewed
Oct 3, 2024
Comment on lines
174
to
176
| saml2SSOResidentAuthenticatorConfig.setDefinedByType(IdentityConstants.DefinedByType.SYSTEM); | ||
| saml2SSOResidentAuthenticatorConfig.setAuthenticationType( | ||
| IdentityConstants.AuthenticationType.IDENTIFICATION); |
There was a problem hiding this comment.
Shouldn't these test cases should be working without setting these properties explicitly ?
Thisara-Welmilla
force-pushed
the
add-auth-prop
branch
2 times, most recently
from
2ac85c6
to
f30a454
Compare
Thisara-Welmilla
force-pushed
the
add-auth-prop
branch
from
f30a454
to
32e7a86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
With this following properties will be introduce to the authenticator configs and Application Authenticators.
DefinedBy- to indicate whether the authenticator is system-defined or user-defined.AuthenticationType- To indicate whether authenticator is one of followingprocess.
With this PR following changes are added.
NOTE: These property values are hardcoded for now. Saving and retrieving with DBs will supported by a separate PR.