Externalize NavigableMenu
, Dropdown
and Modal
components imported from @wordpress/components
#2042
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
It's part of #1833
NavigableMenu
,Dropdown
andModal
components.Tooltip
position within aModal
before.Screenshots:
📷
NavigableMenu
component on the Reports page📷
Dropdown
component on the Reports page📷
Modal
component on the Edit Free Listings page📷
Tooltip
position of the close button within aModal
for WP >= 6.1Detailed test instructions:
NavigableMenu
component works wellAppTabNav
: The main menu itemsAppSubNav
: The sub-menu items on the Reports pageDropdown
component works wellModal
component works well/wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fproduct-feed&guide=submission-success
'extracted/@wordpress/components'
.Changelog entry