Merge pull request #2042 from woocommerce/dev/1833-externalize-menu-d…

…ropdown-modal Externalize `NavigableMenu`, `Dropdown` and `Modal` components imported from `@wordpress/components`
woocommerce · Aug 9, 2023 · 757ed21 · 757ed21
2 parents ebca4f5 + de3a889
commit 757ed21
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 28 deletions.
diff --git a/js/src/components/app-modal/index.js b/js/src/components/app-modal/index.js
@@ -1,7 +1,7 @@
 /**
  * External dependencies
  */
-import { Modal } from '@wordpress/components';
+import { Modal } from 'extracted/@wordpress/components';
 import classnames from 'classnames';
 
 /**

diff --git a/js/src/components/app-sub-nav/index.js b/js/src/components/app-sub-nav/index.js
@@ -2,7 +2,7 @@
  * External dependencies
  */
 import { Fragment } from '@wordpress/element';
-import { NavigableMenu } from '@wordpress/components';
+import { NavigableMenu } from 'extracted/@wordpress/components';
 import { Link } from '@woocommerce/components';
 import classnames from 'classnames';
 

diff --git a/js/src/components/app-tab-nav/index.js b/js/src/components/app-tab-nav/index.js
@@ -1,7 +1,7 @@
 /**
  * External dependencies
  */
-import { NavigableMenu } from '@wordpress/components';
+import { NavigableMenu } from 'extracted/@wordpress/components';
 import { Link } from '@woocommerce/components';
 import classnames from 'classnames';
 

diff --git a/js/src/css/shared/_gutenberg-components.scss b/js/src/css/shared/_gutenberg-components.scss
@@ -62,24 +62,3 @@
 .components-input-control__suffix {
 	margin-right: $grid-unit;
 }
-
-// Hack to fix the Tooltip position of the top-right side close button in a Modal component.
-// The follow up can be found here: https://github.com/woocommerce/google-listings-and-ads/issues/203
-.components-modal {
-	&__screen-overlay {
-		display: flex;
-		justify-content: center;
-		align-items: center;
-	}
-
-	&__frame {
-		@include break-small {
-			transform: initial;
-			position: relative;
-			top: 0;
-			bottom: 0;
-			left: 0;
-			right: 0;
-		}
-	}
-}
diff --git a/js/src/external-components/woocommerce/filter-picker/index.js b/js/src/external-components/woocommerce/filter-picker/index.js
@@ -8,8 +8,7 @@
  * External dependencies
  */
 import { __ } from '@wordpress/i18n';
-import { Dropdown } from '@wordpress/components';
-import { Button } from 'extracted/@wordpress/components';
+import { Dropdown, Button } from 'extracted/@wordpress/components';
 import { focus } from '@wordpress/dom';
 import classnames from 'classnames';
 import { Component } from '@wordpress/element';

diff --git a/js/src/external-components/wordpress/guide/index.js b/js/src/external-components/wordpress/guide/index.js
@@ -11,8 +11,11 @@
 import classnames from 'classnames';
 import { useState } from '@wordpress/element';
 import { __ } from '@wordpress/i18n';
-import { Modal } from '@wordpress/components';
-import { Button, KeyboardShortcuts } from 'extracted/@wordpress/components';
+import {
+	Modal,
+	Button,
+	KeyboardShortcuts,
+} from 'extracted/@wordpress/components';
 
 /**
  * Internal dependencies