Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: support cross shard DELETE with LIMIT/ORDER BY #14959

Merged
merged 8 commits into from
Jan 24, 2024

use snakecase for constant

3ea0b81
Select commit
Loading
Failed to load commit list.
Merged

planner: support cross shard DELETE with LIMIT/ORDER BY #14959

use snakecase for constant
3ea0b81
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 24, 2024 in 0s

47.36% (+0.03%) compared to 9af8692

View this Pull Request on Codecov

47.36% (+0.03%) compared to 9af8692

Details

Codecov Report

Attention: 313 lines in your changes are missing coverage. Please review.

Comparison is base (9af8692) 47.33% compared to head (3ea0b81) 47.36%.
Report is 13 commits behind head on main.

Files Patch % Lines
go/vt/vtgate/planbuilder/operators/delete.go 0.00% 32 Missing ⚠️
.../vtgate/planbuilder/operators/delete_with_input.go 0.00% 31 Missing ⚠️
go/vt/vtgate/engine/delete_with_input.go 53.70% 23 Missing and 2 partials ⚠️
go/vt/vttablet/onlineddl/executor.go 4.00% 24 Missing ⚠️
.../vt/vtgate/planbuilder/operators/query_planning.go 0.00% 17 Missing ⚠️
go/vt/vtenv/cached_size.go 0.00% 14 Missing ⚠️
go/vt/vtgate/planbuilder/operators/phases.go 0.00% 14 Missing ⚠️
go/vt/vtctl/workflow/server.go 79.66% 10 Missing and 2 partials ⚠️
go/vt/sqlparser/cached_size.go 0.00% 10 Missing ⚠️
go/vt/vttablet/tabletserver/tabletenv/env.go 0.00% 10 Missing ⚠️
... and 50 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14959      +/-   ##
==========================================
+ Coverage   47.33%   47.36%   +0.03%     
==========================================
  Files        1142     1144       +2     
  Lines      239009   239066      +57     
==========================================
+ Hits       113125   113239     +114     
+ Misses     117289   117242      -47     
+ Partials     8595     8585      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov