-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: support cross shard DELETE with LIMIT/ORDER BY #14959
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
d941d5a
to
e194b8b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #14959 +/- ##
==========================================
+ Coverage 47.33% 47.36% +0.03%
==========================================
Files 1142 1144 +2
Lines 239009 239066 +57
==========================================
+ Hits 113125 113239 +114
+ Misses 117289 117242 -47
+ Partials 8595 8585 -10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
… for sending as bindvars, added e2e tests Signed-off-by: Harshit Gangal <[email protected]>
…delete with input Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
1508512
to
3ea0b81
Compare
Description
This PR add support for
Delete
withLimit
optionally havingOrder By
for sharded keyspaces.Related Issue(s)
Checklist
Deployment Notes