New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: support cross shard DELETE with LIMIT/ORDER BY #14959

Merged

harshit-gangal merged 8 commits into vitessio:main from planetscale:delete-limit

Jan 24, 2024

Merged

planner: support cross shard DELETE with LIMIT/ORDER BY #14959

use snakecase for constant

Codecov / codecov/patch succeeded Jan 24, 2024 in 1s

59.08% of diff hit (target 47.33%)

View this Pull Request on Codecov

59.08% of diff hit (target 47.33%)

Annotations

Check warning on line 240 in go/cmd/vtctldclient/command/root.go

codecov / codecov/patch

go/cmd/vtctldclient/command/root.go#L240

Added line #L240 was not covered by tests

Check warning on line 125 in go/cmd/vtctldclient/command/schema.go

codecov / codecov/patch

go/cmd/vtctldclient/command/schema.go#L125

Added line #L125 was not covered by tests

Check warning on line 134 in go/vt/schemadiff/column.go

codecov / codecov/patch

go/vt/schemadiff/column.go#L134

Added line #L134 was not covered by tests

Check warning on line 138 in go/vt/schemadiff/column.go

codecov / codecov/patch

go/vt/schemadiff/column.go#L138

Added line #L138 was not covered by tests

Check warning on line 144 in go/vt/schemadiff/column.go

codecov / codecov/patch

go/vt/schemadiff/column.go#L143-L144

Added lines #L143 - L144 were not covered by tests

Check warning on line 161 in go/vt/schemadiff/column.go

codecov / codecov/patch

go/vt/schemadiff/column.go#L161

Added line #L161 was not covered by tests

Check warning on line 165 in go/vt/schemadiff/column.go

codecov / codecov/patch

go/vt/schemadiff/column.go#L165

Added line #L165 was not covered by tests

Check warning on line 417 in go/vt/schemadiff/table.go

codecov / codecov/patch

go/vt/schemadiff/table.go#L417

Added line #L417 was not covered by tests

Check warning on line 432 in go/vt/schemadiff/table.go

codecov / codecov/patch

go/vt/schemadiff/table.go#L432

Added line #L432 was not covered by tests

Check warning on line 241 in go/vt/sidecardb/sidecardb.go

codecov / codecov/patch

go/vt/sidecardb/sidecardb.go#L241

Added line #L241 was not covered by tests

Check warning on line 3080 in go/vt/sqlparser/cached_size.go

codecov / codecov/patch

go/vt/sqlparser/cached_size.go#L3073-L3080

Added lines #L3073 - L3080 were not covered by tests

Check warning on line 3083 in go/vt/sqlparser/cached_size.go

codecov / codecov/patch

go/vt/sqlparser/cached_size.go#L3082-L3083

Added lines #L3082 - L3083 were not covered by tests

Check warning on line 112 in go/vt/vtctl/grpcvtctldserver/server.go

codecov / codecov/patch

go/vt/vtctl/grpcvtctldserver/server.go#L112

Added line #L112 was not covered by tests

Check warning on line 4994 in go/vt/vtctl/grpcvtctldserver/server.go

codecov / codecov/patch

go/vt/vtctl/grpcvtctldserver/server.go#L4993-L4994

Added lines #L4993 - L4994 were not covered by tests

Check warning on line 428 in go/vt/vtctl/workflow/materializer.go

codecov / codecov/patch

go/vt/vtctl/workflow/materializer.go#L428

Added line #L428 was not covered by tests

Check warning on line 437 in go/vt/vtctl/workflow/materializer.go

codecov / codecov/patch

go/vt/vtctl/workflow/materializer.go#L437

Added line #L437 was not covered by tests

Check warning on line 458 in go/vt/vtctl/workflow/materializer.go

codecov / codecov/patch

go/vt/vtctl/workflow/materializer.go#L458

Added line #L458 was not covered by tests

Check warning on line 162 in go/vt/vtctl/workflow/server.go

codecov / codecov/patch

go/vt/vtctl/workflow/server.go#L162

Added line #L162 was not covered by tests

Check warning on line 591 in go/vt/vtctl/workflow/server.go

codecov / codecov/patch

go/vt/vtctl/workflow/server.go#L590-L591

Added lines #L590 - L591 were not covered by tests

Check warning on line 595 in go/vt/vtctl/workflow/server.go

codecov / codecov/patch

go/vt/vtctl/workflow/server.go#L594-L595

Added lines #L594 - L595 were not covered by tests

Check warning on line 2233 in go/vt/vtctl/workflow/server.go

codecov / codecov/patch

go/vt/vtctl/workflow/server.go#L2233

Added line #L2233 was not covered by tests

Check warning on line 3103 in go/vt/vtctl/workflow/server.go

codecov / codecov/patch

go/vt/vtctl/workflow/server.go#L3101-L3103

Added lines #L3101 - L3103 were not covered by tests

Check warning on line 3239 in go/vt/vtctl/workflow/server.go

codecov / codecov/patch

go/vt/vtctl/workflow/server.go#L3239

Added line #L3239 was not covered by tests

Check warning on line 29 in go/vt/vtenv/cached_size.go

codecov / codecov/patch

go/vt/vtenv/cached_size.go#L22-L29

Added lines #L22 - L29 were not covered by tests

Check warning on line 36 in go/vt/vtenv/cached_size.go

codecov / codecov/patch

go/vt/vtenv/cached_size.go#L31-L36

Added lines #L31 - L36 were not covered by tests

View more details on Codecov