Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate ClientOnly and replace with clientOnly (same as solid-start) #74

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

magne4000
Copy link
Member

@magne4000 magne4000 commented Apr 5, 2024

Closes #72
Closes #73

Deprecated ClientOnly component in favor of more standard clientOnly function.

@magne4000 magne4000 marked this pull request as ready for review April 5, 2024 14:05
@magne4000 magne4000 merged commit c6ca4b5 into main Apr 5, 2024
12 checks passed
@magne4000 magne4000 deleted the feat/client-only branch April 5, 2024 14:06
@brillout
Copy link
Member

brillout commented Apr 6, 2024

Neat, I like that new DX. Thinking of replicating that for vike-{react,vue}.

We should update https://vike.dev/ClientOnly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClientOnly fallback should support SSR ClientOnly fallback triggers with nested unresolved resources
2 participants