Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClientOnly fallback triggers with nested unresolved resources #72

Closed
andriygm opened this issue Apr 3, 2024 · 1 comment · Fixed by #74
Closed

ClientOnly fallback triggers with nested unresolved resources #72

andriygm opened this issue Apr 3, 2024 · 1 comment · Fixed by #74

Comments

@andriygm
Copy link

andriygm commented Apr 3, 2024 •
edited
Loading

ClientOnly has a Suspense boundary, causing any unresolved resources within a ClientOnly to trigger it's own fallback. Instead, it should fallback specifically when the ClientOnly import itself is unresolved.
@magne4000 magne4000 mentioned this issue Apr 5, 2024
Merged
@magne4000
Copy link
Member

ClientOnly component is now replaced by a clientOnly function, which works the same as in solid-start. Published in v0.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: deprecate ClientOnly and replace with clientOnly (same as solid-start) vikejs/vike-solid
2 participants
@magne4000 @andriygm