-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
require puppetlabs/stdlib 9.x #1125
Conversation
debian failures will be fixed in voxpupuli/beaker-hostgenerator#318 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to coordinate all the changes to allow stdlib 9 in the various modules.
}, | ||
{ | ||
"name": "puppetlabs/postgresql", | ||
"version_requirement": ">= 6.5.0 < 10.0.0" | ||
}, | ||
{ | ||
"name": "puppetlabs/stdlib", | ||
"version_requirement": ">= 4.25.0 < 9.0.0" | ||
"version_requirement": ">= 9.0.0 < 10.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this will break the installer.
https://github.com/theforeman/foreman-installer/blob/3e4b572883fec5d5357ee718056a04aabc0bab95/Puppetfile#L3-L5
It would have been so much easier if there was a stdlib 8.y that included the non-deprecated versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. I voted for backporting those, but Puppet didn't want to :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be OK now to allow stdlib 9.x as long as the min version isn't changed and the stdlib:: prefix is backed out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if there was a way to a way to denylist 9.0.0 and 9.1.0 but still allow 9.2+.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically I think you can use >= 4.25.0 < 10 != 9.0.x != 9.1.x
but those versions are valid when using Puppet 7 so I'm not sure it's really correct.
Any news on this? |
dba89db
to
1f716d2
Compare
The `ensure_packages()` function is deprecated. The successor is `stdlib::ensure_packages().
@ekohl rebased it |
The
ensure_packages()
function is deprecated. The successor is `stdlib::ensure_packages().