Update to puppetlabs-stdlib 9.x

[ekohl]

Needs:

• puppetlabs/stdlib: Require 9.x & puppetlabs/concat: Allow 9.x puppet-candlepin#239
• require puppetlabs/stdlib 9.x  puppet-foreman#1125
• puppetlabs/stdlib: Require 9.x && puppet/trusted_ca: Allow 5.x puppet-foreman_proxy_content#453
• Mark compatible with puppetlabs/stdlib 9.x puppet-katello#482
• Update to puppetlabs-stdlib 9.x, allow puppetlabs-concat 9.x & puppet-extlib 7.x puppet-puppet#898
• Mark compatible with puppetlabs-stdlib 9.x, puppetlabs-concat 9.x & puppet-systemd 5.x & 6.x puppet-qpid#186

And a round to update extlib:

• Mark compatible with puppet-extlib 7.x puppet-candlepin#246
• Mark compatible with puppet-extlib 7.x puppet-certs#437
• Mark compatible with puppet-extlib 7.x puppet-foreman#1138
• Mark compatible with puppet-extlib 7.x puppet-foreman_proxy#818
• Mark compatible with puppet-extlib 7.x puppet-foreman_proxy_content#463
• Mark compatible with puppet-extlib 7.x puppet-katello#483
• Mark compatible with puppet-extlib 7.x puppet-pulpcore#314

And possibly more.

[ekohl]

F, [2023-11-07T16:38:22.595255 #24758] FATAL -- : Unable to parse /home/jenkins/workspace/foreman-installer-pr-test/_build/modules/foreman_proxy/manifests/plugin/dns/infoblox.pp because of: unknown data type Stdlib::Ip::Address

This is a problem introduced in puppetlabs-stdlib 9.0.0. puppetlabs/puppetlabs-stdlib#1406 should address this.

I'd have thought https://github.com/theforeman/kafo_module_lint would have caught this in CI, so perhaps we're not running it (properly) in puppet-foreman_proxy..

[evgeni]

I don't think we run module lint (anymore)

[evgeni]

But also, if Puppet doesn't care, why should Kafo?

[ekohl]

Perhaps that's an implementation detail, but for now I think the fastest fix is to make it consistent.

[ekohl]

[test foreman-installer]

[ekohl]

I thought 9.4.1 would have been released, since it's @ https://forge.puppet.com/modules/puppetlabs/stdlib but librarian hasn't found it yet. Could be a cache somewhere.

[Librarian]   Module puppetlabs-stdlib found versions: 9.4.0, 9.3.0, 9.2.0, 9.1.0, 9.0.0, 8.6.0, 8.5.0, 8.4.0, 8.3.0, 8.2.0, 8.1.0, 8.0.0, 7.1.0, 7.0.1, 7.0.0, 6.6.0, 6.5.0, 6.4.0, 6.3.0, 6.2.0, 6.1.0, 6.0.0, 5.2.0, 5.1.0, 5.0.0, 4.25.1, 4.25.0, 4.24.0, 4.23.0, 4.22.0, 4.21.0, 4.20.0, 4.19.0, 4.18.0, 4.17.1, 4.17.0, 4.16.0, 4.15.0, 4.14.0, 4.13.1, 4.13.0, 4.12.0, 4.11.0, 4.10.0, 4.9.1, 4.9.0, 4.8.0, 4.7.0, 4.6.0, 4.5.1, 4.5.0, 4.4.0, 4.3.2, 4.3.0, 4.2.2, 4.2.1, 4.2.0, 4.1.0, 3.2.2, 3.2.1, 3.2.0, 3.1.1, 3.1.0, 3.0.1, 3.0.0, 2.6.0, 2.5.1, 2.5.0, 2.4.0, 2.3.3, 2.3.2, 2.3.1, 2.3.0, 2.2.1, 2.2.0, 2.1.3, 2.0.0, 1.1.0, 1.0.0, 0.1.7, 0.1.6, 0.1.5, 0.1.4, 0.1.3, 0.1.2, 0.1.1

[evgeni]

[test foreman-installer]

[evgeni]

FATAL -- : Unable to parse /home/jenkins/workspace/foreman-installer-pr-test/_build/modules/foreman_proxy/manifests/plugin/dns/infoblox.pp because of: data type not recognized Variant[
rake aborted!

This is new

[evgeni]

Aaand multi line definitions strike again!
https://github.com/puppetlabs/puppetlabs-stdlib/blob/main/types/ip/address.pp

type Stdlib::IP::Address = Variant[
  Stdlib::IP::Address::V4,
  Stdlib::IP::Address::V6,
]

😞

[evgeni]

theforeman/kafo#367

[ekohl]

Now updated with a dependency on kafo 7.3+

[ekohl]

COPR fails because it doesn't have Kafo 7.3.0: theforeman/foreman-packaging#9966 & theforeman/foreman-packaging#9967

[evgeni]

Yeah, don't mind copr/packit IMHO :)

[ekohl]

I was waiting for those to build so the nightly package would also be built. That is the case now.