Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require puppetlabs/stdlib 9.x #1125

Merged
merged 2 commits into from
Nov 7, 2023
Merged

require puppetlabs/stdlib 9.x #1125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eebd182
require puppetlabs/stdlib 9.x
bastelfreak Jul 28, 2023
c266b2a
puppetlabs/concat: Allow 9.x
bastelfreak Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/providers.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
String $oauth_package = $foreman::providers::params::oauth_package,
) inherits foreman::providers::params {
if $oauth {
ensure_packages([$oauth_package])
stdlib::ensure_packages([$oauth_package])
anchor { 'foreman::providers::oauth': } # lint:ignore:anchor_resource
Anchor <| title == 'foreman::repo' |> -> Package[$oauth_package] -> Anchor['foreman::providers::oauth']
}
Expand Down
4 changes: 2 additions & 2 deletions metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,15 @@
},
{
"name": "puppetlabs/concat",
"version_requirement": ">= 1.0.0 < 9.0.0"
"version_requirement": ">= 1.0.0 < 10.0.0"
},
{
"name": "puppetlabs/postgresql",
"version_requirement": ">= 6.5.0 < 10.0.0"
},
{
"name": "puppetlabs/stdlib",
"version_requirement": ">= 4.25.0 < 9.0.0"
"version_requirement": ">= 9.0.0 < 10.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this will break the installer.
https://github.com/theforeman/foreman-installer/blob/3e4b572883fec5d5357ee718056a04aabc0bab95/Puppetfile#L3-L5

It would have been so much easier if there was a stdlib 8.y that included the non-deprecated versions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. I voted for backporting those, but Puppet didn't want to :(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be OK now to allow stdlib 9.x as long as the min version isn't changed and the stdlib:: prefix is backed out.

Copy link
Contributor

@jhoblitt jhoblitt Aug 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if there was a way to a way to denylist 9.0.0 and 9.1.0 but still allow 9.2+.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically I think you can use >= 4.25.0 < 10 != 9.0.x != 9.1.x but those versions are valid when using Puppet 7 so I'm not sure it's really correct.

},
{
"name": "puppet/extlib",
Expand Down