[WIP] model + adapters #5
Conversation
| // perhaps add a DirectoryInterface extending FileInterface? | ||
| // with the methods isDirectory and getDirectory, | ||
| // getDirectory returns the parent | ||
| // see also directory methods Local adapter |
There was a problem hiding this comment.
in phpcr there is nt:folder which we also have a document class for in phpcr-odm
There was a problem hiding this comment.
yes exactly, for PHPCR we want to use the nt:folder as "directory". I think we need to add something like ``directoryClass` to the constructor aswell. Or when using FileProviders, it can be abstracted there.
|
mixins are PHPCR level constructs. the primary node type tells what properties a node may have. it can also allow everything, as nt:unstructured does. but nt:file for example defines exactly what fields a node can have. mixins can be added to a node to tell it may have or must have additional properties. to see an example mixin, see here: https://github.com/doctrine/phpcr-odm/blob/master/lib/Doctrine/ODM/PHPCR/Tools/Console/Command/RegisterSystemNodeTypesCommand.php#L63 there is a mixins xml element in the xml/yml mapping and a mixins property of document for annotation. to provide the new node type, we need to define an initializer service in MenuBundle. wanted to link you the doc and noticed its missing, so i just created it: symfony-cmf/symfony-cmf-docs#163 |
|
ok, cool! The interfaces are ready now imho. This evening I will work on creating PRs and move the PHPCR-ODM Image logic to CmfMedia. I will "try out" the documentation for the mixins and Repository Initializers then :-) |
|
I think this is now ready for review. I will leave defining the mixins to the hackday. There is one issue, the stream is not saved in the embedded |
|
you should rebase on master and update the composer.json dependencies accordingly |
|
also some tests would be nice :) |
| * determine the identifier) | ||
| */ | ||
| public function __construct( | ||
| ObjectManager $manager, |
There was a problem hiding this comment.
Should this be ManagerRegistry? And so we should also have setManagerName etc. ?
There was a problem hiding this comment.
ah yes, forget that one, will update.
|
For tests have a look at the |
|
@lsmith77 rebased Yes, quickly writing tests is something I have to learn. (@dantleech I am looking forward to learn from the docs.) Depending on when we want to release I would need some help or someone else can pick this up I guess (I don't mind anyways). |
|
i suggest we solve the obvious and trivial issues and then merge this PR and create new issues so we can fix them individually and add tests. gaufrette is not important for images in sonata admin or replacing the phpcr-odm image for example... |
Related to: