Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to disable auto flush #7

Closed
dbu opened this issue Jun 20, 2013 · 1 comment
Closed

option to disable auto flush #7

dbu opened this issue Jun 20, 2013 · 1 comment

Comments

@dbu
Copy link
Member

dbu commented Jun 20, 2013

in Adapter/Gaufrette/CmfMediaDoctrine.php we have to flush after each write as gaufrette clients expect a file system behaviour. on the other hand, most of the time there will only be one operation i guess? if we go though a web interface, we upload 1 file or delete 1 file or edit 1 file, not several at once. so i guess its not that important all in all.

as the write methods will be called by generic code not knowing or caring about the optional flush parameter, we should have another way to handle this. i would propose we have a global config option on this class whether to autoflush (expected gaufrette behaviour) or not and expose some sort of getObjectManager method so that the user can flush it if needed. such as a method setAutoFlush(false)

see also #5 and KnpLabs/Gaufrette#186

@dbu
Copy link
Member Author

dbu commented Aug 15, 2013

fixed in #27

@dbu dbu closed this as completed Aug 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant