Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Added slideshow block and CmfMedia #189

Closed
wants to merge 6 commits into from
Closed

[WIP] Added slideshow block and CmfMedia #189

wants to merge 6 commits into from

Conversation

rmsint
Copy link
Contributor

@rmsint rmsint commented Jul 19, 2013

_Do not merge, the source branch of this PR needs to be changed to prepare-next-version._

Can be used to test CmfMedia

To test:

  • checkout this PR
  • add the MediaBundle and LiipImagineBundle to composer (dev-master)
composer require liip/imagine-bundle symfony-cmf/media-bundle

TODO to finish:

  • rebase this PR on the prepare-next-release branch - the related block bundle PR (Update ImagineBlock to use CmfMedia image block-bundle#72) must be rebased first
  • update cmf_block.imagine.multilang_slideshow_admin to updated block
  • update create image config
  • close this PR and create a new one setting the branch source to the prepare-next-release branch

@rmsint
Copy link
Contributor Author

rmsint commented Aug 9, 2013

rebased on recent master and updated AdminDashboardTest

model_class: Symfony\Cmf\Bundle\CreateBundle\Document\Image
controller_class: Symfony\Cmf\Bundle\CreateBundle\Controller\PHPCRImageController
model_class: Symfony\Cmf\Bundle\MediaBundle\Doctrine\Phpcr\Image
controller_class: Symfony\Cmf\Bundle\CreateBundle\Controller\ImageController
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these not be default values and not need to be specified?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, will look into this.

@dbu
Copy link
Member

dbu commented Aug 15, 2013

imo its ok to not add fixtures in this PR, there is #132 for that.

@rmsint
Copy link
Contributor Author

rmsint commented Aug 15, 2013

Moved to a new PR to change the source branch to prepare-next-version: #195

@rmsint rmsint closed this Aug 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants