Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indigo test with .travis.rosinstall & add kinetic test #566

Merged
merged 6 commits into from
Jan 15, 2020

Conversation

pazeshun
Copy link
Contributor

@pazeshun pazeshun commented Dec 21, 2019

@pazeshun
Copy link
Contributor Author

Building hrpsys_gazebo_tutorials failed on kinetic, because hrpsys_gazebo_general is not released on kinetic:

Errors << hrpsys_gazebo_tutorials:cmake /workspace/ros/ws_rtmros_tutorials/logs/hrpsys_gazebo_tutorials/build.cmake.000.log
CMake Warning at /opt/ros/kinetic/share/catkin/cmake/catkinConfig.cmake:76 (find_package):

  Could not find a package configuration file provided by

  "hrpsys_gazebo_general" with any of the following names:



    hrpsys_gazebo_generalConfig.cmake

    hrpsys_gazebo_general-config.cmake



  Add the installation prefix of "hrpsys_gazebo_general" to CMAKE_PREFIX_PATH

  or set "hrpsys_gazebo_general_DIR" to a directory containing one of the

  above files.  If "hrpsys_gazebo_general" provides a separate development

  package or SDK, be sure it has been installed.

Call Stack (most recent call first):

  CMakeLists.txt:4 (find_package)





CMake Error at /opt/ros/kinetic/share/catkin/cmake/catkinConfig.cmake:83 (find_package):

  Could not find a package configuration file provided by

  "hrpsys_gazebo_general" with any of the following names:



    hrpsys_gazebo_generalConfig.cmake

    hrpsys_gazebo_general-config.cmake



  Add the installation prefix of "hrpsys_gazebo_general" to CMAKE_PREFIX_PATH

  or set "hrpsys_gazebo_general_DIR" to a directory containing one of the

  above files.  If "hrpsys_gazebo_general" provides a separate development

  package or SDK, be sure it has been installed.

Call Stack (most recent call first):

  CMakeLists.txt:4 (find_package)





cd /workspace/ros/ws_rtmros_tutorials/build/hrpsys_gazebo_tutorials; catkin build --get-env hrpsys_gazebo_tutorials | catkin env -si  /usr/bin/cmake /workspace/ros/ws_rtmros_tutorials/src/rtmros_tutorials/hrpsys_gazebo_tutorials --no-warn-unused-cli -DCATKIN_DEVEL_PREFIX=/workspace/ros/ws_rtmros_tutorials/devel/.private/hrpsys_gazebo_tutorials -DCMAKE_INSTALL_PREFIX=/workspace/ros/ws_rtmros_tutorials/install; cd -

...............................................................................
Failed << hrpsys_gazebo_tutorials:cmake               [ Exited with code 1 ]

(from https://travis-ci.org/start-jsk/rtmros_tutorials/jobs/628036347)

@pazeshun pazeshun force-pushed the fix-indigo-src-add-kinetic branch from 561e44d to 0880f70 Compare December 22, 2019 07:16
@pazeshun
Copy link
Contributor Author

I found there are two test_samplerobot_hrpsys:
https://github.com/start-jsk/rtmros_tutorials/blob/0.1.6/hrpsys_ros_bridge_tutorials/test/test_hrpsys_pa10.launch#L12
https://github.com/start-jsk/rtmros_tutorials/blob/0.1.6/hrpsys_ros_bridge_tutorials/test/test_hrpsys_samplerobot.launch#L18
If there are two ros tests which have the same name, the result of the firstly executed one is overwritten by the secondly executed one.
On indigo test, the result of the former one (test of PA10) is overwritten.
So I fixed this test name to test_pa10_hrpsys at b1abcf7.

Then I found test_pa10_hrpsys always fails (see https://travis-ci.org/start-jsk/rtmros_tutorials/builds/628279441).
Previously, we couldn't find that because the test result was overwritten.
I found the failure cause is lacking of start_omninames.sh in test_hrpsys_pa10.launch, and fixed that at 0880f70.
(In contrast, test_hrpsys_samplerobot.launch already has start_omninames.sh, so its tests pass: https://github.com/start-jsk/rtmros_tutorials/blob/0.1.6/hrpsys_ros_bridge_tutorials/test/test_hrpsys_samplerobot.launch#L8-L9)

@pazeshun
Copy link
Contributor Author

pazeshun commented Dec 22, 2019

@YoheiKakiuchi Could you review & merge this?

@pazeshun
Copy link
Contributor Author

@YoheiKakiuchi Kindly ping.

Copy link
Member

@YoheiKakiuchi YoheiKakiuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pazeshun
Copy link
Contributor Author

@k-okada @YoheiKakiuchi Could you merge this?

@pazeshun
Copy link
Contributor Author

pazeshun commented Jan 6, 2020

@k-okada @YoheiKakiuchi Kindly ping

@pazeshun
Copy link
Contributor Author

@k-okada Kindly ping

@k-okada k-okada merged commit 1989b66 into start-jsk:master Jan 15, 2020
@pazeshun pazeshun deleted the fix-indigo-src-add-kinetic branch January 15, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants