-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Trial to fix travis #564
Conversation
Travis passed, because building with rtmros_hrp2 is not tested (reported in #560 (comment)). I assume travis test on master branch will fail even after this PR is merged, because rtmros_hrp2 is downloaded in that test and building with rtmros_hrp2 + released multisense_ros fails: To avoid that, we need to download multisense_ros 3.4.9 like https://github.com/start-jsk/rtmros_hrp2/blob/master/rtmros_hrp2.rosinstall, in travis test on master. |
Failure in
This is because rtmros_tutorials exists in |
Target package itself should be excluded from .travis.rosinstall
Test with |
This assumption doesn't seem correct, because travis test of rtmros_tutorials currently uses jenkins. On https://github.com/start-jsk/rtmros_tutorials/blob/0.1.6/.travis.yml#L38 and https://github.com/start-jsk/rtmros_tutorials/blob/0.1.6/.travis.yml#L40, Real example:
|
55fe58e
to
1860b81
Compare
I expected that rtmros_hrp2 can be downloaded on jenkins, but that expectation wasn't correct:
(from https://travis-ci.org/start-jsk/rtmros_tutorials/jobs/624933226) |
Moved to https://github.com/start-jsk/rtmros_hrp2/pull/548, #565, and #566 |
First, I update .travis to jsk_travis 0.5.7 to avoid the following error:
(from https://travis-ci.org/start-jsk/rtmros_tutorials/jobs/617687743)