-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sqlite3Worker1Promiser
type declarations
#54
base: main
Are you sure you want to change the base?
Conversation
This is going to need lots of overloads:
|
sqlite3Worker1Promiser
type declarationssqlite3Worker1Promiser
type declarations
Hi, I wanted to let you know that I am currently working on writing the types. I expect to be in a position to share my work with you in the next few days. |
Hey, I just added some partial types to a project recently. They are not comprehensive by any means, but maybe they can serve to get started or to get some ideas: https://github.com/moodlehq/moodleapp/blob/main/src/types/sqlite-wasm.d.ts |
Hi, |
Note that the messageId is an internal-use property used for dispatching messages between the worker and callbacks. It is hypothetically conceivable for clients to tinker with but no actual use for that comes to mind. FWIW, IMO messageId should be flagged as an opaque type of no interest to clients. |
Hi, I made a PR to merge with this adding most of the |
Also copying over my progress comment avoid splitting overall progress discussion:
|
Add types for `Sqlite3Worker1Promiser`
Fixes #53