Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for Sqlite3Worker1Promiser #76

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

sameoldlab
Copy link

No description provided.

@sameoldlab
Copy link
Author

sameoldlab commented May 28, 2024

Progress:

  • Mostly done with Sqlite3Worker1PromiserConfig. Not sure what goes in for the args of generateMessageId
  • Need clearer documentation for Promiser Method open's filename and vfs
  • exec needs to add a full list of arguments, js eqivalent for sql VALUE value used in row and bind
  • There is additional metadata returned by Promiser. Described as "// possibly other metadata ..." on sqlite docs. Not sure how stable these are / if they should be documented here.
  • Need to add type for Promiser response error stack trace array

As the methods are very similar to worker1, I'm hoping I can reduce what is specified here and reuse the existing types where possible.

@tomayac
Copy link
Collaborator

tomayac commented May 28, 2024

How does this relate to #54? Could you maybe join forces?

@sameoldlab
Copy link
Author

sameoldlab commented May 28, 2024

How does this relate to #54? Could you maybe join forces?

Yes, It's for the same issue. I made my PR against the sqlite:types-improvement branch, so ideally that could get merged to main when everything is complete.

@sameoldlab
Copy link
Author

In that case would it make more sense for me to mark this as ready for review now and then track progress in #54?

@tomayac
Copy link
Collaborator

tomayac commented May 28, 2024

I think so, yes. Please ask someone from #54 for a review, and let's then merge it, so from thereon you can continue working on #54. Thanks!

@sameoldlab sameoldlab marked this pull request as ready for review May 28, 2024 07:56
@tomayac tomayac merged commit 14a23c0 into sqlite:types-improvement Jun 3, 2024
@tomayac
Copy link
Collaborator

tomayac commented Jun 3, 2024

Merged, as whatever you have is better than the stub we had in #54. Let's continue the work on #54. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants