Improve types #75
Improve types #75
Conversation
| @@ -5729,7 +5737,7 @@ declare type CAPI = { | |||
| * | |||
| * See https://www.sqlite.org/c3ref/vfs_find.html | |||
| */ | |||
| sqlite3_vfs_find: (vfsName: string) => sqlite3_vfs; | |||
| sqlite3_vfs_find: (vfsName: string|null) => WasmPointer; | |||
There was a problem hiding this comment.
find doesn't return the vfs directly, needs a separate new sqlite_vfs(ptr) call.
Also, it's allowed to pass null to get the default vfs
| @@ -2032,7 +2032,15 @@ declare type Sqlite3Static = { | |||
| installVfs: (obj: { | |||
| io?: { | |||
| struct: sqlite3_io_methods; | |||
| methods: Omit<sqlite3_io_methods, 'iVersion'>; | |||
| methods: { [K in keyof sqlite3_io_methods as K extends `x${string}` ? K : never]?: sqlite3_io_methods[K] }; | |||
There was a problem hiding this comment.
I think it's better to pick all properties that start with x (e.g. xRead, xWrite, etc) rather than omit known static properties, specially for sqlite_vfs below which has a lot more of them.
|
i'm not clear how i can help here - this is all part of the TypeScript stuff, whereas we use only vanilla JS in the core. :-? |
|
Having TypeScript background would help (I'm not deeply into it either), but maybe some of the comments could help you as the implementer make sense of it? // Give the `sqlite3_vfs_find` function an argument
// `vfsName` that's either a string, or null, and the result
// will be a `WasmPointer`.
sqlite3_vfs_find: (vfsName: string|null) => WasmPointer;Else, we can also just "YOLO-merge" it and hope for the best |
|
i'm not at all clear what should be merged or what the patch is about. All i see is some typescript stuff and what might be a suggestion that we rename VFS properties in the core (which would break backwards compatibility, so won't happen). :-? |
|
@GabrielDelepine or @jbaiter from #54 might be able to review this?! Else, I'll just "YOLO-merge" it. |
There is no proposal to rename VFS properties in this PR, it is all based on how the API works as of 3.45.3. The proposal is related to expressing the type of the |
|
Published as |
Improves some type info related to VFS